Re: [PATCH 1/3] [gdb/testsuite] Don't start gdb in gdb.base/gstack.exp

[Tom de Vries <tdevries@suse.de>]

On 2/17/25 18:20, Keith Seitz wrote:
> Hi,
> 
> On 2/17/25 8:36 AM, Tom de Vries wrote:
>> In test-case gdb.base/gstack.exp we start a gdb implicitly using
>> prepare_for_testing.
> 
> Oh, ouch! That is totally my bad!
> 
>> Fix this by:
>> - using build_executable instead of prepare_for_testing to not spawn 
>> an unused
>>    gdb, and
>> - changing the gdb_test_multiple into a gdb_expect, eliminating the 
>> implicit use
>>    of gdb_spawn_id.
> 
> Thank you for catching this and cleaning it up. Truly appreciated.
> 

Hi Keith,

thanks for the review.

The problem really is that it's very easy to overlook this, because 
there's no explicit feedback about left-over processes.  Even more so if 
you run one test-case at a time, because the left-over processes are 
immediately cleaned up.

I'm hoping to eventually submit a patch that monitors and reports 
left-over processes.

For now, I've pushed this.

Thanks,
- Tom

> Reviewed-By: Keith Seitz <keiths@redhat.com>
> 
> Keith
>