From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id xitTOvc9tGdyGzUAWB0awg (envelope-from ) for ; Tue, 18 Feb 2025 02:59:51 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=pRYhIA7E; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=nl4Y4OAz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=pRYhIA7E; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=nl4Y4OAz; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id DDEAD1E105; Tue, 18 Feb 2025 02:59:51 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 329DE1E08E for ; Tue, 18 Feb 2025 02:59:51 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A64A03858C66 for ; Tue, 18 Feb 2025 07:59:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A64A03858C66 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=pRYhIA7E; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=nl4Y4OAz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=pRYhIA7E; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=nl4Y4OAz Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id 1B49B3858D20 for ; Tue, 18 Feb 2025 07:59:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1B49B3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1B49B3858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1739865549; cv=none; b=PTGokPROfajHnDz2KyjzjXvMPjlxy3lL02wAqkXI3mec2+r3lb4IZxb/sOgjX/onlUvSdV/cmjGo/RaikIyCJVLBJC46AQubgtXvLyfIS+ZBO47M9EaIlXB/H1Kvyg7HwrkbNpK/GCmzF+EeQHEXyn2vRHcglzHZPgvkXNj/wOI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1739865549; c=relaxed/simple; bh=sHph8COUkjD+CEPUpo2i6D3R1At2Fcnh3DkzVfcvbWI=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=V+8NT6qp92avJP+wSw9e6rSH3M5RwV8z2QrfhI34vI+w7IUnf+igsB5dsNCLRAeBDXadbKfKAYJXhyXLUI94GzAmb8hvHW4k+YBFRsgkqR20710SzKD6U/vbp6G7wVn61ue0l4Z0HN0VnH74vYF0xYjcqLFxiOqjPnLXlKEYhPs= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1B49B3858D20 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 137B821160; Tue, 18 Feb 2025 07:59:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1739865548; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=j3MUNfhR05fdOYH8ojPiO9lbj1Naltyx4yEv8wmsnA0=; b=pRYhIA7E8yjWtEZxmWaEIyAgc3dm9gw0vZ/UARGIjJD1O6HUhU4GF7jX5+g3/cDUCR/rME 9SwE+jrbJinmSaMXZwhCgde9jIzDqwb4JHAJ9QmA9RnyfJr5A0XesIr1sCKdzzix2tzsI2 bweObUgvWgBoNjq0ovyofJMg2bQs0+0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1739865548; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=j3MUNfhR05fdOYH8ojPiO9lbj1Naltyx4yEv8wmsnA0=; b=nl4Y4OAzWNRsJHxqvdQdYwQl03wqyInVpS2tXKdchfFSdGuyLdUv1FliUKjV/KkFC43fCx 9re6xg55+1A9a6Dw== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1739865548; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=j3MUNfhR05fdOYH8ojPiO9lbj1Naltyx4yEv8wmsnA0=; b=pRYhIA7E8yjWtEZxmWaEIyAgc3dm9gw0vZ/UARGIjJD1O6HUhU4GF7jX5+g3/cDUCR/rME 9SwE+jrbJinmSaMXZwhCgde9jIzDqwb4JHAJ9QmA9RnyfJr5A0XesIr1sCKdzzix2tzsI2 bweObUgvWgBoNjq0ovyofJMg2bQs0+0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1739865548; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=j3MUNfhR05fdOYH8ojPiO9lbj1Naltyx4yEv8wmsnA0=; b=nl4Y4OAzWNRsJHxqvdQdYwQl03wqyInVpS2tXKdchfFSdGuyLdUv1FliUKjV/KkFC43fCx 9re6xg55+1A9a6Dw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id EDE5D132C7; Tue, 18 Feb 2025 07:59:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id ZZlZOMs9tGetUQAAD6G6ig (envelope-from ); Tue, 18 Feb 2025 07:59:07 +0000 Message-ID: <281c4bbc-b1f6-4d67-a49c-4dbfc698839b@suse.de> Date: Tue, 18 Feb 2025 08:59:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] [gdb/testsuite] Don't start gdb in gdb.base/gstack.exp To: Keith Seitz , gdb-patches@sourceware.org References: <20250217163619.8662-1-tdevries@suse.de> <20250217163619.8662-2-tdevries@suse.de> <7338bd81-e9e8-4e81-82d1-a22ac47c5519@redhat.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <7338bd81-e9e8-4e81-82d1-a22ac47c5519@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2/17/25 18:20, Keith Seitz wrote: > Hi, > > On 2/17/25 8:36 AM, Tom de Vries wrote: >> In test-case gdb.base/gstack.exp we start a gdb implicitly using >> prepare_for_testing. > > Oh, ouch! That is totally my bad! > >> Fix this by: >> - using build_executable instead of prepare_for_testing to not spawn >> an unused >>    gdb, and >> - changing the gdb_test_multiple into a gdb_expect, eliminating the >> implicit use >>    of gdb_spawn_id. > > Thank you for catching this and cleaning it up. Truly appreciated. > Hi Keith, thanks for the review. The problem really is that it's very easy to overlook this, because there's no explicit feedback about left-over processes. Even more so if you run one test-case at a time, because the left-over processes are immediately cleaned up. I'm hoping to eventually submit a patch that monitors and reports left-over processes. For now, I've pushed this. Thanks, - Tom > Reviewed-By: Keith Seitz > > Keith >