From: Keith Seitz <keiths@redhat.com>
To: Tom de Vries <tdevries@suse.de>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/3] [gdb/testsuite] Don't start gdb in gdb.base/gstack.exp
Date: Mon, 17 Feb 2025 09:20:05 -0800 [thread overview]
Message-ID: <7338bd81-e9e8-4e81-82d1-a22ac47c5519@redhat.com> (raw)
In-Reply-To: <20250217163619.8662-2-tdevries@suse.de>
Hi,
On 2/17/25 8:36 AM, Tom de Vries wrote:
> In test-case gdb.base/gstack.exp we start a gdb implicitly using
> prepare_for_testing.
Oh, ouch! That is totally my bad!
> Fix this by:
> - using build_executable instead of prepare_for_testing to not spawn an unused
> gdb, and
> - changing the gdb_test_multiple into a gdb_expect, eliminating the implicit use
> of gdb_spawn_id.
Thank you for catching this and cleaning it up. Truly appreciated.
Reviewed-By: Keith Seitz <keiths@redhat.com>
Keith
next prev parent reply other threads:[~2025-02-17 17:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-17 16:36 [PATCH 0/3] [gdb/testsuite] Clean up left-over processes Tom de Vries
2025-02-17 16:36 ` [PATCH 1/3] [gdb/testsuite] Don't start gdb in gdb.base/gstack.exp Tom de Vries
2025-02-17 17:20 ` Keith Seitz [this message]
2025-02-18 7:59 ` Tom de Vries
2025-02-17 16:36 ` [PATCH 2/3] [gdb/testsuite] Kill left-over process in gdb.base/add-symbol-file-attach.exp Tom de Vries
2025-02-24 17:26 ` Tom Tromey
2025-02-24 17:57 ` Tom de Vries
2025-02-24 18:05 ` Tom Tromey
2025-02-24 18:43 ` Tom de Vries
2025-02-17 16:36 ` [PATCH 3/3] [gdb/testsuite] Exit left-over gdb in gdb.mi/mi-break.exp Tom de Vries
2025-02-24 17:28 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7338bd81-e9e8-4e81-82d1-a22ac47c5519@redhat.com \
--to=keiths@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox