From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 8b4CFQVws2eWgzQAWB0awg (envelope-from ) for ; Mon, 17 Feb 2025 12:21:09 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=aqGEPgMC; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 457E41E105; Mon, 17 Feb 2025 12:21:09 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_SBL_CSS autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4FDAB1E05C for ; Mon, 17 Feb 2025 12:21:04 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 862D83858C78 for ; Mon, 17 Feb 2025 17:21:03 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 862D83858C78 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=aqGEPgMC Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id BA6003858C33 for ; Mon, 17 Feb 2025 17:20:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BA6003858C33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BA6003858C33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1739812809; cv=none; b=x4Hc1Xb0nXi3WPaTgTYzitB+1R93IpoKPjdkqzGgY7ts/ZhLqbLZGstwyQ8qWQA1fc2OV4Hw6Be+dqAFGx7s8uMgigPHbgD7tRR/CNHkTMh8tLQxRwPbYuYWEb8i4CNaGYYfGvXlareMSRGMQaZsd9a3GPKbw5dfeKPDDEkce9M= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1739812809; c=relaxed/simple; bh=FijhfiElrnuOQRAVRihiw4oNgVFVweVLtO0/WRD+jeQ=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=wD4RzPFeHQLgR1QolkQtkbGJ08V0206+9ze3WwIlTtQq6mCAb/tyTQtNol61WICgrQ+9EV3d5t6xTiuK1SL1AvtM3nHjoezhi1Vjp3Kf1U/zrson8VCEq+I8/+uz7nT3FvgURvdE0KrTejlipzDqpI3Y/NV2Vz05COI45uOKpDY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BA6003858C33 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739812809; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Juw2msKW/7BkVTEpZvyw6dnTYK0/gWxI5QypWYQCevw=; b=aqGEPgMCLOEMMG7fQX9VPf58re3HiPrHoxprJfw3FIq6gkLn6pfsfEOquVlcsVn3gKzCE7 lf3d0vopcHS4rfvC6RfWt9khqqT4xqauT5ZvJmS6nS60/NcLVZljofQ8CrMR8rDwg1VJxw wuVOkOTW0q/1nolMtS1aLsQ54Uuum0g= Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-312-HEKhB9-jOLuCVEx9ANTcNA-1; Mon, 17 Feb 2025 12:20:08 -0500 X-MC-Unique: HEKhB9-jOLuCVEx9ANTcNA-1 X-Mimecast-MFC-AGG-ID: HEKhB9-jOLuCVEx9ANTcNA_1739812807 Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-2f816a85facso9136547a91.3 for ; Mon, 17 Feb 2025 09:20:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739812807; x=1740417607; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Juw2msKW/7BkVTEpZvyw6dnTYK0/gWxI5QypWYQCevw=; b=iWShEuhrVUXt3/u+ArjAQ8s3lrdkgOD984+DGeuqbY406DriRNaaa5M4h0v0WF3FGR ihbL8jIOk48eafSDT7ykdIhzFZUrWIcKTBAwo15/ppNjG3Fl9yur6UaZ7IBDeAzzR3jj i7Y36/qFEqYafAJhw4W5oaJyw/LgCJGtnJHl5csGcKz8OJWkdHyi8Kl5VOZH1OZSfK9A m9syF2+xzs8X4NvrVcXVze2zQqQkcsKZfO/9mTQUWMO/m+zlM6wKzsI1BHuIBpKlj6YB qWReAzqTczTXpzmxRIry/bgPdsV6FnJhqSc/Hg5ILdw/aRYrxM+BcDNiGQrxH1Gx+7uz 8o/A== X-Forwarded-Encrypted: i=1; AJvYcCXJ2gSWXPyrdiJYtO1vBh6Uru0DjKtaZDlSZ7biW+mtp6dOSxGlJT1tRXwljdL/wp+YPR3JZ20MM41L2A==@sourceware.org X-Gm-Message-State: AOJu0Yxzdi+UXkIZzFfMT4JM5cWqvH0OvToOeFeBRpGlGRZEFb+fLjab /naymHK55+UZtX3I11lLcwYhBspmeJ/uVrUkQ1CaMPcKnvlVLE32Cmo88B7H7eVBpl73iXmVNah nd0HVOsXM13bucfxHPEjBsD7laZH1+rlWN8liYeN9teftTPyzhFC/keKK9T0= X-Gm-Gg: ASbGnctR8cJpDItHpJCEGJshcamQXd6KN3v4adGmd2KyBkvBM2F9WESsQ6BuJsTdA40 DGMEnuRhhGbuHmjSZpddwkgd/jAYC9j8SboxfBiTUba54SigHflnNx/Yk/yiLzJhvqDx/9Rna3L zdiY6skvbYIb9LFe/wE8B/UslH95FN1ys3KXjH2yo6jvPSDkEYQsLG3fh0gpHQBxAfRFGC+60xq phsTRWYQZxXC6kPQnPSTmtxbFnOaQigjeEnLBSALml/hDphPRDeRJR/lbmKaV+l+rHxw1tu4Lwd gl7dBW6xSwM= X-Received: by 2002:a17:90b:3886:b0:2ee:d433:7c50 with SMTP id 98e67ed59e1d1-2fc4104509fmr12544493a91.23.1739812807215; Mon, 17 Feb 2025 09:20:07 -0800 (PST) X-Google-Smtp-Source: AGHT+IF9aKb1zEkEbMSUlILz4D6VRfA7OuxVTTh3vEjyrRK+gQi0DCbEtnWq6FQuEP6UVFjVYdOmEg== X-Received: by 2002:a17:90b:3886:b0:2ee:d433:7c50 with SMTP id 98e67ed59e1d1-2fc4104509fmr12544468a91.23.1739812806888; Mon, 17 Feb 2025 09:20:06 -0800 (PST) Received: from [150.1.200.127] ([172.56.107.180]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2fc13ad2f56sm8437575a91.24.2025.02.17.09.20.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Feb 2025 09:20:06 -0800 (PST) Message-ID: <7338bd81-e9e8-4e81-82d1-a22ac47c5519@redhat.com> Date: Mon, 17 Feb 2025 09:20:05 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] [gdb/testsuite] Don't start gdb in gdb.base/gstack.exp To: Tom de Vries , gdb-patches@sourceware.org References: <20250217163619.8662-1-tdevries@suse.de> <20250217163619.8662-2-tdevries@suse.de> From: Keith Seitz In-Reply-To: <20250217163619.8662-2-tdevries@suse.de> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: dPhnhQQY7-D-ky6S6YvoDSQpjOQdAARilr2415N_smg_1739812807 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hi, On 2/17/25 8:36 AM, Tom de Vries wrote: > In test-case gdb.base/gstack.exp we start a gdb implicitly using > prepare_for_testing. Oh, ouch! That is totally my bad! > Fix this by: > - using build_executable instead of prepare_for_testing to not spawn an unused > gdb, and > - changing the gdb_test_multiple into a gdb_expect, eliminating the implicit use > of gdb_spawn_id. Thank you for catching this and cleaning it up. Truly appreciated. Reviewed-By: Keith Seitz Keith