From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id vOArM0+zvGetTjwAWB0awg (envelope-from ) for ; Mon, 24 Feb 2025 12:58:39 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=u62CxTA2; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=ObNrVHQS; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=u62CxTA2; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=ObNrVHQS; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id BA38D1E105; Mon, 24 Feb 2025 12:58:39 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2E5DD1E05C for ; Mon, 24 Feb 2025 12:58:38 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 890EB3858D29 for ; Mon, 24 Feb 2025 17:58:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 890EB3858D29 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=u62CxTA2; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=ObNrVHQS; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=u62CxTA2; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=ObNrVHQS Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 9A6EE3858CDB for ; Mon, 24 Feb 2025 17:57:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9A6EE3858CDB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9A6EE3858CDB Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1740419834; cv=none; b=Sv6b2qk5NmXf6fzI9z2QPCO7M2MZm68CXvei57FaYA4748WM0mdWWlUJ1kbHZqjNbri91tW8CgrO0r+b0gsgNAoIuojKqY3bVviSLsn3KrMI85utED06kPTPbKG2HR1LE1E41xFT/QKyxQjOe1kGpC0Mb6ndp8vwOjWZPfP12pY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1740419834; c=relaxed/simple; bh=kbRKC6F3RdT5PgcOHjPTRAfgrhL22VTn9PfnmIkitH0=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=iF5wp2pPSGXQ/4iBjGmlXtyc+kzdKKJDhaFwXaPMUSNS8QhetwAeTN9SR1cGMv5KEakZGtueAYcUTMK4iT1h8NtT6HG2gLb5cM5pQaX9SQMXuQGDR+TEmvxQdccmdPW8hZObAj3RFre9Ps6AmdoO8dsT/Zh1Wb8xF1PyO/rdXqI= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9A6EE3858CDB Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 89B5321171; Mon, 24 Feb 2025 17:57:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1740419833; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nu8J564JdXu2xUS0adIn5drpu9b8oTCHV1P6zsegjt4=; b=u62CxTA2WZ5Km6f8SAPuSJnbgAS3/TwXq/ASEgYmTgkPN3cWZZibZFA2yvrb2/vhlSW/Md FUfB5TuB5eI8+oft9YZ2MjHBGDw0+KfzBgv9c1kPoLb0vKomCOh3L7mcUKjtkCNtL6Jmzq wD+Hbq366M20YH5e+eesr0Fy5fa6NgQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1740419833; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nu8J564JdXu2xUS0adIn5drpu9b8oTCHV1P6zsegjt4=; b=ObNrVHQS3DDzd9kT0GyglQoCvlBdEiv0dl9MVyy4IA4QuGQ3vvx+VbZhtvy/yF7haR3+mO P13Vfe/Kltl4EYDQ== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=u62CxTA2; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=ObNrVHQS DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1740419833; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nu8J564JdXu2xUS0adIn5drpu9b8oTCHV1P6zsegjt4=; b=u62CxTA2WZ5Km6f8SAPuSJnbgAS3/TwXq/ASEgYmTgkPN3cWZZibZFA2yvrb2/vhlSW/Md FUfB5TuB5eI8+oft9YZ2MjHBGDw0+KfzBgv9c1kPoLb0vKomCOh3L7mcUKjtkCNtL6Jmzq wD+Hbq366M20YH5e+eesr0Fy5fa6NgQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1740419833; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nu8J564JdXu2xUS0adIn5drpu9b8oTCHV1P6zsegjt4=; b=ObNrVHQS3DDzd9kT0GyglQoCvlBdEiv0dl9MVyy4IA4QuGQ3vvx+VbZhtvy/yF7haR3+mO P13Vfe/Kltl4EYDQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 720FA13707; Mon, 24 Feb 2025 17:57:13 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id iRp5GvmyvGe8DAAAD6G6ig (envelope-from ); Mon, 24 Feb 2025 17:57:13 +0000 Message-ID: <91ab3691-d4a7-4909-9b2c-6d563bb1dad8@suse.de> Date: Mon, 24 Feb 2025 18:57:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] [gdb/testsuite] Kill left-over process in gdb.base/add-symbol-file-attach.exp To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20250217163619.8662-1-tdevries@suse.de> <20250217163619.8662-3-tdevries@suse.de> <87mseb5k5w.fsf@tromey.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <87mseb5k5w.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 89B5321171 X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_BLOCKED(0.00)[rspamd.com]; ARC_NA(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; TO_DN_SOME(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; RCVD_VIA_SMTP_AUTH(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email,suse.de:dkim,suse.de:mid] X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Action: no action X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2/24/25 18:26, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries writes: > > Tom> +require {valid_spawn_id $test_spawn_id} > Tom> +at_finish_kill_wait $test_spawn_id > > Should this really yield unsupported, though, and not a fail? > AFAIU, the only thing that FAIL should be used for, is if gdb is behaving incorrectly. In this case, gdb is not involved, this is just expact spawning a process for gdb to attach to. > Also I was wondering if at_finish_kill_wait should just be implicit in > the spawn. I thought about that as well, but I think there are cases were spawned processes are killed through other means. Maybe we can do this by default, and then add a parameter to disable that to deal with those cases. Thanks, - Tom