Re: [commit] Fix ARI violations in mips-linux-nat.c and mips-tdep.c

["Maciej W. Rozycki" <macro@codesourcery.com>]

On Fri, 9 Mar 2012, Maciej W. Rozycki wrote:

> > >  What about the other issue I noted however, i.e.:
> > > 
> > > gdb/event-loop.c:	perror_with_name (("poll"));
> > > 
> > > vs expected:
> > > 
> > > gdb/event-loop.c:	perror_with_name (_("poll"));
> > > 
> > > (and so on) -- these clearly look like an oversight.
> > 
> > 
> > I don't think so.  I think this is the way to silence the ARI for strings
> > that should not be translated.  See:
> 
>  I didn't know that, thanks.  In this case I think the same should be done 
> with the "ptrace" reference in mips-linux-nat.c.  I'll make a patch 
> shortly.

 This disappeared from my radar for a while, but came back now, and I have 
decided to go for a more verbose error instead after all.  I have checked 
in this update now.

2012-05-22  Maciej W. Rozycki  <macro@codesourcery.com>

	gdb/
	* mips-linux-nat.c (mips_linux_read_description): Use a more
	verbose error message.

  Maciej

gdb-mips-dsp-err.diff
Index: gdb-fsf-trunk-quilt/gdb/mips-linux-nat.c
===================================================================
--- gdb-fsf-trunk-quilt.orig/gdb/mips-linux-nat.c	2012-03-29 23:48:44.000000000 +0100
+++ gdb-fsf-trunk-quilt/gdb/mips-linux-nat.c	2012-05-20 14:09:08.325650594 +0100
@@ -447,7 +447,7 @@ mips_linux_read_description (struct targ
 	  have_dsp = 0;
 	  break;
 	default:
-	  perror_with_name (_("ptrace"));
+	  perror_with_name (_("Couldn't check DSP support"));
 	  break;
 	}
     }