From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18080 invoked by alias); 22 May 2012 18:13:13 -0000 Received: (qmail 18067 invoked by uid 22791); 22 May 2012 18:13:11 -0000 X-SWARE-Spam-Status: No, hits=-4.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 22 May 2012 18:12:56 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1SWtZm-0004jD-Kq from Maciej_Rozycki@mentor.com ; Tue, 22 May 2012 11:12:54 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Tue, 22 May 2012 11:12:54 -0700 Received: from [172.30.0.105] (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.1.289.1; Tue, 22 May 2012 19:12:52 +0100 Date: Tue, 22 May 2012 18:13:00 -0000 From: "Maciej W. Rozycki" To: Pedro Alves CC: Joel Brobecker , Subject: Re: [commit] Fix ARI violations in mips-linux-nat.c and mips-tdep.c In-Reply-To: Message-ID: References: <20120302015615.GA30880@sourceware.org> <1330715778-30398-1-git-send-email-brobecker@adacore.com> <20120309041102.GA2853@adacore.com> <4F59E7B7.4060501@redhat.com> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00840.txt.bz2 On Fri, 9 Mar 2012, Maciej W. Rozycki wrote: > > > What about the other issue I noted however, i.e.: > > > > > > gdb/event-loop.c: perror_with_name (("poll")); > > > > > > vs expected: > > > > > > gdb/event-loop.c: perror_with_name (_("poll")); > > > > > > (and so on) -- these clearly look like an oversight. > > > > > > I don't think so. I think this is the way to silence the ARI for strings > > that should not be translated. See: > > I didn't know that, thanks. In this case I think the same should be done > with the "ptrace" reference in mips-linux-nat.c. I'll make a patch > shortly. This disappeared from my radar for a while, but came back now, and I have decided to go for a more verbose error instead after all. I have checked in this update now. 2012-05-22 Maciej W. Rozycki gdb/ * mips-linux-nat.c (mips_linux_read_description): Use a more verbose error message. Maciej gdb-mips-dsp-err.diff Index: gdb-fsf-trunk-quilt/gdb/mips-linux-nat.c =================================================================== --- gdb-fsf-trunk-quilt.orig/gdb/mips-linux-nat.c 2012-03-29 23:48:44.000000000 +0100 +++ gdb-fsf-trunk-quilt/gdb/mips-linux-nat.c 2012-05-20 14:09:08.325650594 +0100 @@ -447,7 +447,7 @@ mips_linux_read_description (struct targ have_dsp = 0; break; default: - perror_with_name (_("ptrace")); + perror_with_name (_("Couldn't check DSP support")); break; } }