Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Maciej W. Rozycki" <macro@codesourcery.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [commit] Fix ARI violations in mips-linux-nat.c and mips-tdep.c
Date: Fri, 09 Mar 2012 00:42:00 -0000	[thread overview]
Message-ID: <alpine.DEB.1.10.1203090032340.14492@tp.orcam.me.uk> (raw)
In-Reply-To: <1330715778-30398-1-git-send-email-brobecker@adacore.com>

On Fri, 2 Mar 2012, Joel Brobecker wrote:

> diff --git a/gdb/mips-linux-nat.c b/gdb/mips-linux-nat.c
> index af472df..b63be2e 100644
> --- a/gdb/mips-linux-nat.c
> +++ b/gdb/mips-linux-nat.c
> @@ -447,7 +447,7 @@ mips_linux_read_description (struct target_ops *ops)
>  	  have_dsp = 0;
>  	  break;
>  	default:
> -	  perror_with_name ("ptrace");
> +	  perror_with_name (_("ptrace"));
>  	  break;
>  	}
>      }

 Hmm, I'm not sure if "ptrace" can be translated to anything as it's a 
proper name; however if you're in a picky mood, then watch out for 
numerous cases like this:

gdb/event-loop.c:	perror_with_name (("poll"));

including a zillion in gdb/inf-ttrace.c.

  Maciej


  reply	other threads:[~2012-03-09  0:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-02  1:56 New ARI warning Fri Mar 2 01:56:15 UTC 2012 GDB Administrator
2012-03-02 19:16 ` [commit] Fix ARI violations in mips-linux-nat.c and mips-tdep.c Joel Brobecker
2012-03-09  0:42   ` Maciej W. Rozycki [this message]
2012-03-09  4:11     ` Joel Brobecker
2012-03-09  8:16       ` Maciej W. Rozycki
2012-03-09 11:22         ` Pedro Alves
2012-03-09 11:29           ` Maciej W. Rozycki
2012-05-22 18:13             ` Maciej W. Rozycki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.1.10.1203090032340.14492@tp.orcam.me.uk \
    --to=macro@codesourcery.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox