From: "Maciej W. Rozycki" <macro@codesourcery.com>
To: Pedro Alves <palves@redhat.com>
Cc: Joel Brobecker <brobecker@adacore.com>, <gdb-patches@sourceware.org>
Subject: Re: [commit] Fix ARI violations in mips-linux-nat.c and mips-tdep.c
Date: Fri, 09 Mar 2012 11:29:00 -0000 [thread overview]
Message-ID: <alpine.DEB.1.10.1203091128080.14492@tp.orcam.me.uk> (raw)
In-Reply-To: <4F59E7B7.4060501@redhat.com>
On Fri, 9 Mar 2012, Pedro Alves wrote:
> > What about the other issue I noted however, i.e.:
> >
> > gdb/event-loop.c: perror_with_name (("poll"));
> >
> > vs expected:
> >
> > gdb/event-loop.c: perror_with_name (_("poll"));
> >
> > (and so on) -- these clearly look like an oversight.
>
>
> I don't think so. I think this is the way to silence the ARI for strings
> that should not be translated. See:
I didn't know that, thanks. In this case I think the same should be done
with the "ptrace" reference in mips-linux-nat.c. I'll make a patch
shortly.
Maciej
next prev parent reply other threads:[~2012-03-09 11:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-02 1:56 New ARI warning Fri Mar 2 01:56:15 UTC 2012 GDB Administrator
2012-03-02 19:16 ` [commit] Fix ARI violations in mips-linux-nat.c and mips-tdep.c Joel Brobecker
2012-03-09 0:42 ` Maciej W. Rozycki
2012-03-09 4:11 ` Joel Brobecker
2012-03-09 8:16 ` Maciej W. Rozycki
2012-03-09 11:22 ` Pedro Alves
2012-03-09 11:29 ` Maciej W. Rozycki [this message]
2012-05-22 18:13 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.10.1203091128080.14492@tp.orcam.me.uk \
--to=macro@codesourcery.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox