From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-88707-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 25995 invoked by alias); 9 Mar 2012 11:29:57 -0000
Received: (qmail 25986 invoked by uid 22791); 9 Mar 2012 11:29:56 -0000
X-SWARE-Spam-Status: No, hits=-1.7 required=5.0	tests=AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 09 Mar 2012 11:29:43 +0000
Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93])	by relay1.mentorg.com with esmtp 	id 1S5y0z-0003To-HT from Maciej_Rozycki@mentor.com ; Fri, 09 Mar 2012 03:29:41 -0800
Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675);	 Fri, 9 Mar 2012 03:29:41 -0800
Received: from [172.30.13.7] (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.1.289.1; Fri, 9 Mar 2012 11:29:38 +0000
Date: Fri, 09 Mar 2012 11:29:00 -0000
From: "Maciej W. Rozycki" <macro@codesourcery.com>
To: Pedro Alves <palves@redhat.com>
CC: Joel Brobecker <brobecker@adacore.com>, <gdb-patches@sourceware.org>
Subject: Re: [commit] Fix ARI violations in mips-linux-nat.c and mips-tdep.c
In-Reply-To: <4F59E7B7.4060501@redhat.com>
Message-ID: <alpine.DEB.1.10.1203091128080.14492@tp.orcam.me.uk>
References: <20120302015615.GA30880@sourceware.org> <1330715778-30398-1-git-send-email-brobecker@adacore.com> <alpine.DEB.1.10.1203090032340.14492@tp.orcam.me.uk> <20120309041102.GA2853@adacore.com> <alpine.DEB.1.10.1203090724540.14492@tp.orcam.me.uk> <4F59E7B7.4060501@redhat.com>
User-Agent: Alpine 1.10 (DEB 962 2008-03-14)
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-03/txt/msg00329.txt.bz2

On Fri, 9 Mar 2012, Pedro Alves wrote:

> >  What about the other issue I noted however, i.e.:
> > 
> > gdb/event-loop.c:	perror_with_name (("poll"));
> > 
> > vs expected:
> > 
> > gdb/event-loop.c:	perror_with_name (_("poll"));
> > 
> > (and so on) -- these clearly look like an oversight.
> 
> 
> I don't think so.  I think this is the way to silence the ARI for strings
> that should not be translated.  See:

 I didn't know that, thanks.  In this case I think the same should be done 
with the "ptrace" reference in mips-linux-nat.c.  I'll make a patch 
shortly.

  Maciej