Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: gdb-patches@sourceware.org
Cc: Joel Brobecker <brobecker@adacore.com>
Subject: [commit] Fix ARI violations in mips-linux-nat.c and mips-tdep.c
Date: Fri, 02 Mar 2012 19:16:00 -0000	[thread overview]
Message-ID: <1330715778-30398-1-git-send-email-brobecker@adacore.com> (raw)
In-Reply-To: <20120302015615.GA30880@sourceware.org>

Hello,

I checked the following patch in to fix a couple of new ARI violations.
Once again the Linux kernel vs GNU/Linux rule strikes, and once again,
I find that it makes the text harder to read...

gdb/ChangeLog:

        * mips-linux-nat.c (mips_linux_read_description): Add missing i18n
        marker.
        * mips-tdep.c (mips_linux_reg_names): Improve comment to avoid ARI
        violation.

Checked in.

---
 gdb/ChangeLog        |    7 +++++++
 gdb/mips-linux-nat.c |    2 +-
 gdb/mips-tdep.c      |    2 +-
 3 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index ca22249..2ef9591 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,10 @@
+2012-03-02  Joel Brobecker  <brobecker@adacore.com>
+
+	* mips-linux-nat.c (mips_linux_read_description): Add missing i18n
+	marker.
+	* mips-tdep.c (mips_linux_reg_names): Improve comment to avoid ARI
+	violation.
+
 2012-03-02  Pedro Alves  <palves@redhat.com>
 
 	* linux-thread-db.c (attach_thread): Avoid in_thread_list call.
diff --git a/gdb/mips-linux-nat.c b/gdb/mips-linux-nat.c
index af472df..b63be2e 100644
--- a/gdb/mips-linux-nat.c
+++ b/gdb/mips-linux-nat.c
@@ -447,7 +447,7 @@ mips_linux_read_description (struct target_ops *ops)
 	  have_dsp = 0;
 	  break;
 	default:
-	  perror_with_name ("ptrace");
+	  perror_with_name (_("ptrace"));
 	  break;
 	}
     }
diff --git a/gdb/mips-tdep.c b/gdb/mips-tdep.c
index 6c78640..013b07c 100644
--- a/gdb/mips-tdep.c
+++ b/gdb/mips-tdep.c
@@ -428,7 +428,7 @@ static const char *mips_irix_reg_names[NUM_MIPS_PROCESSOR_REGS] = {
   "pc", "cause", "bad", "hi", "lo", "fsr", "fir"
 };
 
-/* Names of Linux registers.  */
+/* Names of registers with Linux kernels.  */
 static const char *mips_linux_reg_names[NUM_MIPS_PROCESSOR_REGS] = {
   "sr", "lo", "hi", "bad", "cause", "pc",
   "f0", "f1", "f2", "f3", "f4", "f5", "f6", "f7",
-- 
1.7.1


  reply	other threads:[~2012-03-02 19:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-02  1:56 New ARI warning Fri Mar 2 01:56:15 UTC 2012 GDB Administrator
2012-03-02 19:16 ` Joel Brobecker [this message]
2012-03-09  0:42   ` [commit] Fix ARI violations in mips-linux-nat.c and mips-tdep.c Maciej W. Rozycki
2012-03-09  4:11     ` Joel Brobecker
2012-03-09  8:16       ` Maciej W. Rozycki
2012-03-09 11:22         ` Pedro Alves
2012-03-09 11:29           ` Maciej W. Rozycki
2012-05-22 18:13             ` Maciej W. Rozycki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1330715778-30398-1-git-send-email-brobecker@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox