Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Maciej W. Rozycki" <macro@codesourcery.com>
To: "Pinski, Andrew" <Andrew.Pinski@caviumnetworks.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
	"pinskia@gmail.com" <pinskia@gmail.com>
Subject: RE: [PATCH/MIPS] Add support Octeon's bbit instructions
Date: Tue, 24 Apr 2012 19:44:00 -0000	[thread overview]
Message-ID: <alpine.DEB.1.10.1204242012360.19835@tp.orcam.me.uk> (raw)
In-Reply-To: <5A31B467E5043B4C9104F558E9137E4E324F3E7025@VA3DIAXVS3E1.RED001.local>

On Fri, 20 Apr 2012, Pinski, Andrew wrote:

> Here is the updated patch with the style fixes and one extra change as I 
> noticed itype_op (inst) was being called a few times in mips32_next_pc, 
> I merged all of them into one variable.

 Thanks for doing this, I meant to do such a change as the next step.  
However I'd prefer functionally separate changes to be made as separate 
commits, so please split this change into two, first that eliminates the 
repetitive itype_op (inst) operations, and second that adds your new 
feature.

>  And renamed is_octeon_bit_op to 
> is_octeon_bbit_op since the instructions are named bbit and not bit.

 Thanks, that looks reasonable to me.  Please also take into account my 
previous comment about function documentation that Joel has been kind 
enough to reiterate.

 OK with these changes.

  Maciej


  parent reply	other threads:[~2012-04-24 19:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-15 16:49 Andrew Pinski
2012-04-19 13:38 ` Maciej W. Rozycki
2012-04-20 22:56   ` Pinski, Andrew
2012-04-20 23:37     ` Joel Brobecker
2012-04-24 19:44     ` Maciej W. Rozycki [this message]
2012-08-19 22:19       ` Andrew Pinski
2012-08-23 16:27         ` Tom Tromey
2012-08-23 20:43           ` Andrew Pinski
2012-08-24 13:57             ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.1.10.1204242012360.19835@tp.orcam.me.uk \
    --to=macro@codesourcery.com \
    --cc=Andrew.Pinski@caviumnetworks.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pinskia@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox