From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9122 invoked by alias); 24 Apr 2012 19:27:40 -0000 Received: (qmail 9114 invoked by uid 22791); 24 Apr 2012 19:27:39 -0000 X-SWARE-Spam-Status: No, hits=-4.1 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 24 Apr 2012 19:27:27 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1SMlOX-0007Wr-2P from Maciej_Rozycki@mentor.com ; Tue, 24 Apr 2012 12:27:25 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Tue, 24 Apr 2012 12:27:24 -0700 Received: from [172.30.0.81] (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.1.289.1; Tue, 24 Apr 2012 20:27:23 +0100 Date: Tue, 24 Apr 2012 19:44:00 -0000 From: "Maciej W. Rozycki" To: "Pinski, Andrew" CC: "gdb-patches@sourceware.org" , "pinskia@gmail.com" Subject: RE: [PATCH/MIPS] Add support Octeon's bbit instructions In-Reply-To: <5A31B467E5043B4C9104F558E9137E4E324F3E7025@VA3DIAXVS3E1.RED001.local> Message-ID: References: , <5A31B467E5043B4C9104F558E9137E4E324F3E7025@VA3DIAXVS3E1.RED001.local> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00823.txt.bz2 On Fri, 20 Apr 2012, Pinski, Andrew wrote: > Here is the updated patch with the style fixes and one extra change as I > noticed itype_op (inst) was being called a few times in mips32_next_pc, > I merged all of them into one variable. Thanks for doing this, I meant to do such a change as the next step. However I'd prefer functionally separate changes to be made as separate commits, so please split this change into two, first that eliminates the repetitive itype_op (inst) operations, and second that adds your new feature. > And renamed is_octeon_bit_op to > is_octeon_bbit_op since the instructions are named bbit and not bit. Thanks, that looks reasonable to me. Please also take into account my previous comment about function documentation that Joel has been kind enough to reiterate. OK with these changes. Maciej