RE: [PATCH/MIPS] Add support Octeon's bbit instructions

Maciej W. Rozycki
2012-04-24T19:27:40Z

On Fri, 20 Apr 2012, Pinski, Andrew wrote:

> Here is the updated patch with the style fixes and one extra change as I
> noticed itype_op (inst) was being called a few times in mips32_next_pc,
> I merged all of them into one variable.

Thanks for doing this, I meant to do such a change as the next step.
However I'd prefer functionally separate changes to be made as separate
commits, so please split this change into two, first that eliminates the
repetitive itype_op (inst) operations, and second that adds your new
feature.

> And renamed is_octeon_bit_op to
> is_octeon_bbit_op since the instructions are named bbit and not bit.

Thanks, that looks reasonable to me. Please also take into account my
previous comment about function documentation that Joel has been kind
enough to reiterate.

OK with these changes.

Maciej