From: Tom Tromey <tromey@redhat.com>
To: Andrew Pinski <andrew.pinski@cavium.com>
Cc: Andrew Pinski <andrew.pinski@caviumnetworks.com>,
"Maciej W. Rozycki" <macro@codesourcery.com>,
"gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH/MIPS] Add support Octeon's bbit instructions
Date: Fri, 24 Aug 2012 13:57:00 -0000 [thread overview]
Message-ID: <87a9xkmlzw.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1345754613.22460.1.camel@apinskidesktop> (Andrew Pinski's message of "Thu, 23 Aug 2012 13:43:33 -0700")
Andrew> Yes please write the patch and I will test it.
Give this a try.
Also, I think the copyright info in this file is wrong.
It says copyright Cavium Networks -- but presumably it was assigned.
And it uses GPL v2, not v3.
Tom
diff --git a/gdb/testsuite/gdb.arch/mips-octeon-bbit.exp b/gdb/testsuite/gdb.arch/mips-octeon-bbit.exp
index de6db0f..096c56f 100644
--- a/gdb/testsuite/gdb.arch/mips-octeon-bbit.exp
+++ b/gdb/testsuite/gdb.arch/mips-octeon-bbit.exp
@@ -77,22 +77,13 @@ proc test_bbit { name taken } {
}
}
-set testfile "mips-octeon-bbit"
-set srcfile ${testfile}.c
-set binfile ${objdir}/${subdir}/${testfile}
+standard_testfile .c
-if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable \
- {debug nowarnings}] != "" } {
- fail "compilation"
- return
+if { [prepare_for_testing ${testfile}.exp ${testfile} ${srcfile} \
+ {debug nowarnings}] } {
+ return -1
}
-pass "compilation"
-
-gdb_exit
-gdb_start
-gdb_reinitialize_dir $srcdir/$subdir
-gdb_load ${binfile}
# Native needs run.
runto_main
prev parent reply other threads:[~2012-08-24 13:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-15 16:49 Andrew Pinski
2012-04-19 13:38 ` Maciej W. Rozycki
2012-04-20 22:56 ` Pinski, Andrew
2012-04-20 23:37 ` Joel Brobecker
2012-04-24 19:44 ` Maciej W. Rozycki
2012-08-19 22:19 ` Andrew Pinski
2012-08-23 16:27 ` Tom Tromey
2012-08-23 20:43 ` Andrew Pinski
2012-08-24 13:57 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a9xkmlzw.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=andrew.pinski@cavium.com \
--cc=andrew.pinski@caviumnetworks.com \
--cc=gdb-patches@sourceware.org \
--cc=macro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox