From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-94093-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 16674 invoked by alias); 24 Aug 2012 13:57:09 -0000
Received: (qmail 16665 invoked by uid 22791); 24 Aug 2012 13:57:08 -0000
X-SWARE-Spam-Status: No, hits=-6.6 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 24 Aug 2012 13:56:56 +0000
Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7ODuroY012770	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Fri, 24 Aug 2012 09:56:53 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q7ODuq7Q024444	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Fri, 24 Aug 2012 09:56:52 -0400
From: Tom Tromey <tromey@redhat.com>
To: Andrew Pinski <andrew.pinski@cavium.com>
Cc: Andrew Pinski <andrew.pinski@caviumnetworks.com>,        "Maciej W. Rozycki" <macro@codesourcery.com>,        "gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH/MIPS] Add support Octeon's bbit instructions
References: <CA+=Sn1mwHXVa7_-ktwgQVNq2ZyX8bQEjhj95ZbyWpTbVGPQixg@mail.gmail.com>	<alpine.DEB.1.10.1204191322460.19835@tp.orcam.me.uk>	<5A31B467E5043B4C9104F558E9137E4E324F3E7025@VA3DIAXVS3E1.RED001.local>	<alpine.DEB.1.10.1204242012360.19835@tp.orcam.me.uk>	<CA+=Sn1kktQHNzbyLAEKDk+=Dau_V8nEkmW9_pUPMtWyNAjwpxg@mail.gmail.com>	<87d32hpo9m.fsf@fleche.redhat.com>	<1345754613.22460.1.camel@apinskidesktop>
Date: Fri, 24 Aug 2012 13:57:00 -0000
In-Reply-To: <1345754613.22460.1.camel@apinskidesktop> (Andrew Pinski's	message of "Thu, 23 Aug 2012 13:43:33 -0700")
Message-ID: <87a9xkmlzw.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-08/txt/msg00722.txt.bz2

Andrew> Yes please write the patch and I will test it.  

Give this a try.

Also, I think the copyright info in this file is wrong.
It says copyright Cavium Networks -- but presumably it was assigned.
And it uses GPL v2, not v3.

Tom

diff --git a/gdb/testsuite/gdb.arch/mips-octeon-bbit.exp b/gdb/testsuite/gdb.arch/mips-octeon-bbit.exp
index de6db0f..096c56f 100644
--- a/gdb/testsuite/gdb.arch/mips-octeon-bbit.exp
+++ b/gdb/testsuite/gdb.arch/mips-octeon-bbit.exp
@@ -77,22 +77,13 @@ proc test_bbit { name taken } {
     }
 }
 
-set testfile "mips-octeon-bbit"
-set srcfile ${testfile}.c
-set binfile ${objdir}/${subdir}/${testfile}
+standard_testfile .c
 
-if  { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable \
-       {debug nowarnings}] != "" } {
-     fail "compilation"
-     return
+if { [prepare_for_testing ${testfile}.exp ${testfile} ${srcfile} \
+	  {debug nowarnings}] } {
+    return -1
 }
 
-pass "compilation"
-
-gdb_exit
-gdb_start
-gdb_reinitialize_dir $srcdir/$subdir
-gdb_load ${binfile}
 # Native needs run.
 runto_main