From: Joel Brobecker <brobecker@adacore.com>
To: "Pinski, Andrew" <Andrew.Pinski@caviumnetworks.com>
Cc: "Maciej W. Rozycki" <macro@codesourcery.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
"pinskia@gmail.com" <pinskia@gmail.com>
Subject: Re: [PATCH/MIPS] Add support Octeon's bbit instructions
Date: Fri, 20 Apr 2012 23:37:00 -0000 [thread overview]
Message-ID: <20120420233546.GK2852@adacore.com> (raw)
In-Reply-To: <5A31B467E5043B4C9104F558E9137E4E324F3E7025@VA3DIAXVS3E1.RED001.local>
Hi Andrew,
This is a superficial review, I was just glancing at the diff
for no real reason when I spotted a couple of little nits. They
may be specific to the GDB project...
> +/* Return nonzero if the gdbarch is an Octeon series. */
> +static int
> +is_octeon (struct gdbarch *gdbarch)
We'd like to have one empty line between the function documentation
and its declaration. Also, 2 spaces after the period :-).
--
Joel
next prev parent reply other threads:[~2012-04-20 23:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-15 16:49 Andrew Pinski
2012-04-19 13:38 ` Maciej W. Rozycki
2012-04-20 22:56 ` Pinski, Andrew
2012-04-20 23:37 ` Joel Brobecker [this message]
2012-04-24 19:44 ` Maciej W. Rozycki
2012-08-19 22:19 ` Andrew Pinski
2012-08-23 16:27 ` Tom Tromey
2012-08-23 20:43 ` Andrew Pinski
2012-08-24 13:57 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120420233546.GK2852@adacore.com \
--to=brobecker@adacore.com \
--cc=Andrew.Pinski@caviumnetworks.com \
--cc=gdb-patches@sourceware.org \
--cc=macro@codesourcery.com \
--cc=pinskia@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox