Re: [PATCH/MIPS] Add support Octeon's bbit instructions

Andrew Pinski
2012-08-23T20:43:56Z

On Thu, 2012-08-23 at 10:27 -0600, Tom Tromey wrote:
> >>>>> "Andrew" == Andrew Pinski <andrew.pinski@caviumnetworks.com> writes:
>
> I know this is in already, but at least for future reference (or now if
> you don't mind changing it)...

Thanks, I will remember this for next time.

>
> Andrew> +set testfile "mips-octeon-bbit"
> Andrew> +set srcfile ${testfile}.c
> Andrew> +set binfile ${objdir}/${subdir}/${testfile}
>
> Use standard_testfile.c
>
> Andrew> +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable \
> Andrew> + {debug nowarnings}] != "" } {
> Andrew> + fail "compilation"
> Andrew> + return
> Andrew> +}
> Andrew> +
> Andrew> +pass "compilation"
> Andrew> +
> Andrew> +gdb_exit
> Andrew> +gdb_start
> Andrew> +gdb_reinitialize_dir $srcdir/$subdir
> Andrew> +gdb_load ${binfile}
>
> All this can be replaced with prepare_for_testing.
>
> If you want, I can write a patch, if you would test it.

Yes please write the patch and I will test it.

Thanks,
Andrew Pinski