From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10850 invoked by alias); 20 Apr 2012 23:36:16 -0000 Received: (qmail 10815 invoked by uid 22791); 20 Apr 2012 23:36:15 -0000 X-SWARE-Spam-Status: No, hits=-3.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_HOSTKARMA_NO,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 20 Apr 2012 23:36:00 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id A3CB91C63F5; Fri, 20 Apr 2012 19:35:59 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id T3UV1PH6DMUO; Fri, 20 Apr 2012 19:35:59 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 278EA1C63B8; Fri, 20 Apr 2012 19:35:58 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 12E9F145616; Fri, 20 Apr 2012 16:35:46 -0700 (PDT) Date: Fri, 20 Apr 2012 23:37:00 -0000 From: Joel Brobecker To: "Pinski, Andrew" Cc: "Maciej W. Rozycki" , "gdb-patches@sourceware.org" , "pinskia@gmail.com" Subject: Re: [PATCH/MIPS] Add support Octeon's bbit instructions Message-ID: <20120420233546.GK2852@adacore.com> References: <5A31B467E5043B4C9104F558E9137E4E324F3E7025@VA3DIAXVS3E1.RED001.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5A31B467E5043B4C9104F558E9137E4E324F3E7025@VA3DIAXVS3E1.RED001.local> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00705.txt.bz2 Hi Andrew, This is a superficial review, I was just glancing at the diff for no real reason when I spotted a couple of little nits. They may be specific to the GDB project... > +/* Return nonzero if the gdbarch is an Octeon series. */ > +static int > +is_octeon (struct gdbarch *gdbarch) We'd like to have one empty line between the function documentation and its declaration. Also, 2 spaces after the period :-). -- Joel