From: Alan Modra <amodra@gmail.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: simon.marchi@polymtl.ca, gdb-patches@sourceware.org,
binutils@sourceware.org
Subject: Re: [PATCH 2/3] opcodes: fix a few -Wdiscarded-qualifiers errors
Date: Tue, 24 Feb 2026 11:44:53 +1030 [thread overview]
Message-ID: <aZz7jV77iyI2t_e7@squeak.grove.modra.org> (raw)
In-Reply-To: <ebc7f37c-e71a-47bc-80cf-beed3565c389@suse.com>
On Mon, Feb 23, 2026 at 03:27:38PM +0100, Jan Beulich wrote:
> On 23.02.2026 14:26, simon.marchi@polymtl.ca wrote:
> > From: Simon Marchi <simon.marchi@polymtl.ca>
> > --- a/opcodes/riscv-dis.c
> > +++ b/opcodes/riscv-dis.c
> > @@ -110,7 +110,7 @@ parse_riscv_dis_option_without_args (const char *option,
> > /* Parse RISC-V disassembler option (possibly with arguments). */
> >
> > static void
> > -parse_riscv_dis_option (const char *option, struct disassemble_info *info)
> > +parse_riscv_dis_option (char *option, struct disassemble_info *info)
> > {
> > char *equal, *value;
> >
> ... this change, while apparently correct, isn't very nice.
I think it both correct and nice. Nice because it removes the lie
that the "option" string is not changed by the function.
--
Alan Modra
next prev parent reply other threads:[~2026-02-24 1:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-23 13:26 [PATCH 0/3] Fix some more " simon.marchi
2026-02-23 13:26 ` [PATCH 1/3] bfd: fix 2 " simon.marchi
2026-02-23 14:20 ` Jan Beulich
2026-02-24 15:36 ` Simon Marchi
2026-02-23 13:26 ` [PATCH 2/3] opcodes: fix a few " simon.marchi
2026-02-23 14:27 ` Jan Beulich
2026-02-24 1:14 ` Alan Modra [this message]
2026-02-24 14:58 ` Keith Seitz
2026-02-24 15:46 ` Simon Marchi
2026-02-24 17:17 ` Keith Seitz
2026-02-24 22:57 ` Alan Modra
2026-02-25 14:50 ` Keith Seitz
2026-02-23 13:26 ` [PATCH 3/3] sim: " simon.marchi
2026-02-26 18:21 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZz7jV77iyI2t_e7@squeak.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=jbeulich@suse.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox