Re: [PATCH 2/3] opcodes: fix a few -Wdiscarded-qualifiers errors

[Simon Marchi <simon.marchi@polymtl.ca>]

On 2026-02-24 09:58, Keith Seitz wrote:
> On 2/23/26 5:26 AM, simon.marchi@polymtl.ca wrote:
>> From: Simon Marchi <simon.marchi@polymtl.ca>
>>
>> diff --git a/opcodes/ip2k-asm.c b/opcodes/ip2k-asm.c
>> index 18bd98a28463..3adbd1546a38 100644
>> --- a/opcodes/ip2k-asm.c
>> +++ b/opcodes/ip2k-asm.c
>> @@ -59,7 +59,7 @@ parse_fr (CGEN_CPU_DESC cd,
>>   {
>>     const char *errmsg;
>>     const char *old_strp;
>> -  char *afteroffset;
>> +  const char *afteroffset;
>>     enum cgen_parse_operand_result result_type;
>>     bfd_vma value;
>>     extern CGEN_KEYWORD ip2k_cgen_opval_register_names;
> 
> The top of this file says:
> 
> """
> /* DO NOT EDIT!  -*- buffer-read-only: t -*- vi:set ro:  */
> /* Assembler interface for targets using CGEN. -*- C -*-
>    CGEN: Cpu tools GENerator
> 
>    THIS FILE IS MACHINE GENERATED WITH CGEN.
>    - the resultant file is machine generated, cgen-asm.in isn't
> [...]
> """
> 
> Is this no longer the case? I was able to regenerate it by modifying
> cpu/ip2k.opc[1].
> 
> Keith
> 
> [1] https://inbox.sourceware.org/binutils/c797abce4ebbaa4e86d404f9fca17b197ceb6b17.1767807388.git.keiths@redhat.com/T/
> 

Oh, good catch.  But wait... why is your patch not merged yet?

Simon