Re: [PATCH 2/3] opcodes: fix a few -Wdiscarded-qualifiers errors

[Jan Beulich <jbeulich@suse.com>]

On 23.02.2026 14:26, simon.marchi@polymtl.ca wrote:
> From: Simon Marchi <simon.marchi@polymtl.ca>
> 
> Change-Id: Ifd43eb7ceee3bebc8be690a7fba94fc8651ffcd6
> ---
>  opcodes/aarch64-dis.c | 2 +-
>  opcodes/ia64-opc.c    | 2 +-
>  opcodes/ip2k-asm.c    | 2 +-
>  opcodes/riscv-dis.c   | 4 ++--
>  opcodes/tilegx-opc.c  | 2 +-
>  opcodes/tilepro-opc.c | 2 +-
>  6 files changed, 7 insertions(+), 7 deletions(-)

Okay, but please allow target maintainers (who you may have wanted to Cc) some
time to chime in. In particular ...

> --- a/opcodes/riscv-dis.c
> +++ b/opcodes/riscv-dis.c
> @@ -110,7 +110,7 @@ parse_riscv_dis_option_without_args (const char *option,
>  /* Parse RISC-V disassembler option (possibly with arguments).  */
>  
>  static void
> -parse_riscv_dis_option (const char *option, struct disassemble_info *info)
> +parse_riscv_dis_option (char *option, struct disassemble_info *info)
>  {
>    char *equal, *value;
>  
... this change, while apparently correct, isn't very nice.

Jan