From: Keith Seitz <keiths@redhat.com>
To: simon.marchi@polymtl.ca, gdb-patches@sourceware.org,
binutils@sourceware.org
Subject: Re: [PATCH 2/3] opcodes: fix a few -Wdiscarded-qualifiers errors
Date: Tue, 24 Feb 2026 06:58:10 -0800 [thread overview]
Message-ID: <6b019870-a3db-4c11-a3f0-1790b4e59071@redhat.com> (raw)
In-Reply-To: <20260223132805.3186869-3-simon.marchi@polymtl.ca>
On 2/23/26 5:26 AM, simon.marchi@polymtl.ca wrote:
> From: Simon Marchi <simon.marchi@polymtl.ca>
>
> diff --git a/opcodes/ip2k-asm.c b/opcodes/ip2k-asm.c
> index 18bd98a28463..3adbd1546a38 100644
> --- a/opcodes/ip2k-asm.c
> +++ b/opcodes/ip2k-asm.c
> @@ -59,7 +59,7 @@ parse_fr (CGEN_CPU_DESC cd,
> {
> const char *errmsg;
> const char *old_strp;
> - char *afteroffset;
> + const char *afteroffset;
> enum cgen_parse_operand_result result_type;
> bfd_vma value;
> extern CGEN_KEYWORD ip2k_cgen_opval_register_names;
The top of this file says:
"""
/* DO NOT EDIT! -*- buffer-read-only: t -*- vi:set ro: */
/* Assembler interface for targets using CGEN. -*- C -*-
CGEN: Cpu tools GENerator
THIS FILE IS MACHINE GENERATED WITH CGEN.
- the resultant file is machine generated, cgen-asm.in isn't
[...]
"""
Is this no longer the case? I was able to regenerate it by modifying
cpu/ip2k.opc[1].
Keith
[1]
https://inbox.sourceware.org/binutils/c797abce4ebbaa4e86d404f9fca17b197ceb6b17.1767807388.git.keiths@redhat.com/T/
next prev parent reply other threads:[~2026-02-24 14:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-23 13:26 [PATCH 0/3] Fix some more " simon.marchi
2026-02-23 13:26 ` [PATCH 1/3] bfd: fix 2 " simon.marchi
2026-02-23 14:20 ` Jan Beulich
2026-02-24 15:36 ` Simon Marchi
2026-02-23 13:26 ` [PATCH 2/3] opcodes: fix a few " simon.marchi
2026-02-23 14:27 ` Jan Beulich
2026-02-24 1:14 ` Alan Modra
2026-02-24 14:58 ` Keith Seitz [this message]
2026-02-24 15:46 ` Simon Marchi
2026-02-24 17:17 ` Keith Seitz
2026-02-24 22:57 ` Alan Modra
2026-02-25 14:50 ` Keith Seitz
2026-02-23 13:26 ` [PATCH 3/3] sim: " simon.marchi
2026-02-26 18:21 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b019870-a3db-4c11-a3f0-1790b4e59071@redhat.com \
--to=keiths@redhat.com \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox