From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id KQgLM7r7nGkl8QcAWB0awg (envelope-from ) for ; Mon, 23 Feb 2026 20:15:38 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=McbRulpy; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id C48AC1E0BA; Mon, 23 Feb 2026 20:15:38 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4CFF01E08D for ; Mon, 23 Feb 2026 20:15:38 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 663FF4B9DB72 for ; Tue, 24 Feb 2026 01:15:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 663FF4B9DB72 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=McbRulpy Received: from mail-pg1-x533.google.com (mail-pg1-x533.google.com [IPv6:2607:f8b0:4864:20::533]) by sourceware.org (Postfix) with ESMTPS id 812934BA2E11 for ; Tue, 24 Feb 2026 01:14:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 812934BA2E11 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 812934BA2E11 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::533 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1771895697; cv=none; b=Z/ZBt30LCxtB/qUIFPs5Hc0lqAfY4XTORmV5BKHoVVUYRzFwgueq/wJLM47Rwoiz+VmzsJQeJXjyMeEC2RwFU82xvzI6WjWWdHk57SzmPE1+kDgpz6N8OyoV+cOtC1BIyeWpWHbGzi6w1NhoZOohoGX/H2sVbeGMg8OcOSgaIKw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1771895697; c=relaxed/simple; bh=1tMjpNUnmmXfUghnUAWXLxwP6Ery0epMWO4tIBdSulY=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=E4S+jHbg5jfa36DHoZ99Bwl5L+Yc2KBq89/XIR9DpPS0DROu69iNh1Th/X889JMWa5auzEWMN84rdyU0A7QLX58+SOHjuAoi9eDm/3qJhOqpxTJK4X4AL7AXjANCCPMJlFYkrQIqTut/jcrcNkTmj6chnAVwY7ojWFnFU1DmarU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 812934BA2E11 Received: by mail-pg1-x533.google.com with SMTP id 41be03b00d2f7-c61343f82d7so1698659a12.1 for ; Mon, 23 Feb 2026 17:14:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771895696; x=1772500496; darn=sourceware.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=InidvRZN/2eDOrFjrBZbP3+QSXGXnT3WnRVUXvYCjWY=; b=McbRulpy+GpYag47rR2VuEjLdFk2I0fiYMHCedYRD7+j6ACDITctXzIL/pFVpYx7iy 9gTRcpesa00A/vAsMjbHlf8d/pwpBL5+9FF/ItwSBFS2rkRam8SieIMdj3dDa0lpb+nr bwXpnXn+DwvNS7hWFp9iVS8vfS7B6dVSItqCNLEBAt0fL4KlyQ+eSqcrSkyv6mydnuAA CWoK1CeEMT1ASCzejb3ADIQcJBnFUxe41S+Qb24dqROWxZ4ejvdQEx9Dxe4XFXt3hx9S BP+AoDoFeXZmy3AUXXJLx7een5PWQ1pqNp0MiRIgyddBAT10oPv5L5DrxfB2ala4SLyA i3FQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771895696; x=1772500496; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=InidvRZN/2eDOrFjrBZbP3+QSXGXnT3WnRVUXvYCjWY=; b=jRF6v/aeLCD1dgOnik9hs6J5T+cdc5Eu6FRwzDS8fDdXON246j/lIaw8u2Qayy16o5 m7oMKi+p8bf633oA50pSeVz9UlbUJlkK8tHmjGC3MCp19rq5S+UwhnzzZ2ViFLPLyHr8 Dr3AwkhwQuQkqmzR43S+9IHYgLKUrK4b8lIbszsj/saBRfH7HpzdHY6ush4ZDufB9g5P gAlMMslgH0QZ95dI7hW9cMklM1YdEyd7KRAD4cRwBxFRjo5/BZDfo4yzVnZDy+7mH9QA OFum52ifkfkxIcnJSB/9MuyXuYTb9cFWdjXAe6M9ujOq3MYAAZG9NsOWbPT7SIaGuBIa IWSQ== X-Forwarded-Encrypted: i=1; AJvYcCW85PbQVGDfBMlhuo/54hAIhf7rRfWLAWor6LVTj4JZuEGcjloXRKfDoJiH7UxUB5aUcLWJtDmAeQ2DWg==@sourceware.org X-Gm-Message-State: AOJu0Yxjx+71PjLhmEPLWvtPr6rk4OItZc6rX+OK2U0prDyYHATNP+HK b6wMNf85nlTYMbq5nyTeSEc/7y58jEv63Da7BScizC1Q/HGT7ahgOZsh X-Gm-Gg: ATEYQzxmWfAu9jqHiqKGnTHOAoZ6iidee1yBmtb5at9DUcJ70bkbBFyCKhymZsg3pm5 SEl/jy3dCO89zis56Af/INf8eX+UgbW/ah5sDXi4N4bo+EbuT9wqYROqGK3SCHJNI4aiCQdoSyy 69jfiReh1ZX1TL88r4yU1bPEgQXY8oM2HJMOWFvcv6ae8iImMMa3WWQIZiSsQa9V5dNB3KunnX5 IZ5W3pegWlYSFWyCvWxcCT9J+2wqvCtgVFFq9G93fOH1SmI7VFRW1dooRRRiMA3ibQlE4M32Y6M Szf++pZP4Axb2kN7ovrbmPmUIUCtIpZF7VIw6+ISzJihxv4kL77lUIdYGogvKxa2A1+4a6T46sD iSAC5NRqf4eibEgBdRHw2beCwTaaL/ChqRvWIHU0KWmkphLiArYI7eu+JIkkbLqaFApwLmbWnYk bZTwsQ7lOTNjbg3ihBroyUkaGESTSlQuHAHFE2WPgFbKyIBhQo37CMgpDBQ1tNqnaWduuOxA== X-Received: by 2002:a17:90b:3d8b:b0:32d:e780:e9d5 with SMTP id 98e67ed59e1d1-358ae8a669cmr6938768a91.22.1771895696321; Mon, 23 Feb 2026 17:14:56 -0800 (PST) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-358df5582d4sm200883a91.11.2026.02.23.17.14.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Feb 2026 17:14:55 -0800 (PST) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 3A8E31140353; Tue, 24 Feb 2026 11:44:53 +1030 (ACDT) Date: Tue, 24 Feb 2026 11:44:53 +1030 From: Alan Modra To: Jan Beulich Cc: simon.marchi@polymtl.ca, gdb-patches@sourceware.org, binutils@sourceware.org Subject: Re: [PATCH 2/3] opcodes: fix a few -Wdiscarded-qualifiers errors Message-ID: References: <20260223132805.3186869-1-simon.marchi@polymtl.ca> <20260223132805.3186869-3-simon.marchi@polymtl.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Mon, Feb 23, 2026 at 03:27:38PM +0100, Jan Beulich wrote: > On 23.02.2026 14:26, simon.marchi@polymtl.ca wrote: > > From: Simon Marchi > > --- a/opcodes/riscv-dis.c > > +++ b/opcodes/riscv-dis.c > > @@ -110,7 +110,7 @@ parse_riscv_dis_option_without_args (const char *option, > > /* Parse RISC-V disassembler option (possibly with arguments). */ > > > > static void > > -parse_riscv_dis_option (const char *option, struct disassemble_info *info) > > +parse_riscv_dis_option (char *option, struct disassemble_info *info) > > { > > char *equal, *value; > > > ... this change, while apparently correct, isn't very nice. I think it both correct and nice. Nice because it removes the lie that the "option" string is not changed by the function. -- Alan Modra