From: Nick Clifton <nickc@redhat.com>
To: John Baldwin <jhb@FreeBSD.org>,
gdb-patches@sourceware.org, binutils@sourceware.org
Subject: Re: [PATCH v2 1/3] Use the ELF class to determine the word size for FreeBSD core notes.
Date: Tue, 13 Dec 2016 11:04:00 -0000 [thread overview]
Message-ID: <a2766669-a187-5623-28cd-7672ba1b27d2@redhat.com> (raw)
In-Reply-To: <20161206210015.40422-2-jhb@FreeBSD.org>
Hi John,
> FreeBSD MIPS64 core dumps contain an empty e_flags value so are assigned
> to the default bfd_arch_mips which is 32-bits.
I am sorry, but I am worried about this patch breaking things for other,
non-MIPS targets. Wouldn't it be easier to update bfd/elfxx-mips.c:_bfd_elf_mips_mach()
to test the EI_CLASS field if no flags are set. Maybe by using the ABI_64_P macro ?
Cheers
Nick
next prev parent reply other threads:[~2016-12-13 11:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-06 21:01 [PATCH v2 0/3] Add FreeBSD/mips targets to GDB John Baldwin
2016-12-06 21:01 ` [PATCH v2 3/3] Add native target for FreeBSD/mips John Baldwin
2016-12-08 18:53 ` Luis Machado
2016-12-08 20:09 ` John Baldwin
2016-12-08 20:15 ` Luis Machado
2016-12-06 21:01 ` [PATCH v2 2/3] Add FreeBSD/mips architecture John Baldwin
2016-12-08 18:47 ` Luis Machado
2016-12-08 20:08 ` John Baldwin
2016-12-08 20:13 ` Luis Machado
2016-12-09 19:02 ` John Baldwin
2016-12-16 12:22 ` GDB attribution policy (Re: [PATCH v2 2/3] Add FreeBSD/mips architecture.) Pedro Alves
2017-01-10 16:19 ` Pedro Alves
2016-12-06 21:01 ` [PATCH v2 1/3] Use the ELF class to determine the word size for FreeBSD core notes John Baldwin
2016-12-13 11:04 ` Nick Clifton [this message]
2016-12-23 20:35 ` John Baldwin
2016-12-16 12:50 ` [PATCH v2 0/3] Add FreeBSD/mips targets to GDB Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2766669-a187-5623-28cd-7672ba1b27d2@redhat.com \
--to=nickc@redhat.com \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=jhb@FreeBSD.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox