Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: John Baldwin <jhb@FreeBSD.org>,
	gdb-patches@sourceware.org,        binutils@sourceware.org
Subject: Re: [PATCH v2 0/3] Add FreeBSD/mips targets to GDB
Date: Fri, 16 Dec 2016 12:50:00 -0000	[thread overview]
Message-ID: <048d53fa-9828-014a-94f0-1bc0f61be5bd@redhat.com> (raw)
In-Reply-To: <20161206210015.40422-1-jhb@FreeBSD.org>

On 12/06/2016 09:00 PM, John Baldwin wrote:
> The first patch works around an issue where FreeBSD/mips core
> dumps from the kernel include an empty ei_flags value in the ELF
> header.  This causes bfd to select the default MIPS architecture
> (bfd_mach_3000) even though it is a 64-bit core file.  As a result,
> parsing the core dump notes doesn't work correctly since bits_per_word
> is 32.  It's not clear to me if bfd shouldn't default to a 64-bit
> MIPS machine if the ELF header indicates a 64-bit class instead of
> this change?
> 
> Changes since the first version are to address most (but perhaps not
> all) of the feedback from Luis Machado on patches 2 and 3.

The GDB changes are OK (once you've addressed the latest minor nits).

Thanks for the patches, and thanks Luis for reviewing this.

New targets/hosts deserve a gdb/NEWS entry.  Can you write one?

Thanks,
Pedro Alves


      parent reply	other threads:[~2016-12-16 12:50 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-06 21:01 John Baldwin
2016-12-06 21:01 ` [PATCH v2 3/3] Add native target for FreeBSD/mips John Baldwin
2016-12-08 18:53   ` Luis Machado
2016-12-08 20:09     ` John Baldwin
2016-12-08 20:15       ` Luis Machado
2016-12-06 21:01 ` [PATCH v2 2/3] Add FreeBSD/mips architecture John Baldwin
2016-12-08 18:47   ` Luis Machado
2016-12-08 20:08     ` John Baldwin
2016-12-08 20:13       ` Luis Machado
2016-12-09 19:02         ` John Baldwin
2016-12-16 12:22   ` GDB attribution policy (Re: [PATCH v2 2/3] Add FreeBSD/mips architecture.) Pedro Alves
2017-01-10 16:19     ` Pedro Alves
2016-12-06 21:01 ` [PATCH v2 1/3] Use the ELF class to determine the word size for FreeBSD core notes John Baldwin
2016-12-13 11:04   ` Nick Clifton
2016-12-23 20:35     ` John Baldwin
2016-12-16 12:50 ` Pedro Alves [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=048d53fa-9828-014a-94f0-1bc0f61be5bd@redhat.com \
    --to=palves@redhat.com \
    --cc=binutils@sourceware.org \
    --cc=gdb-patches@sourceware.org \
    --cc=jhb@FreeBSD.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox