From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23710 invoked by alias); 16 Dec 2016 12:50:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23587 invoked by uid 89); 16 Dec 2016 12:50:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.0 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 16 Dec 2016 12:50:44 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5B70A3D94D; Fri, 16 Dec 2016 12:50:43 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uBGCoXd2014146; Fri, 16 Dec 2016 07:50:37 -0500 Subject: Re: [PATCH v2 0/3] Add FreeBSD/mips targets to GDB To: John Baldwin , gdb-patches@sourceware.org, binutils@sourceware.org References: <20161206210015.40422-1-jhb@FreeBSD.org> From: Pedro Alves Message-ID: <048d53fa-9828-014a-94f0-1bc0f61be5bd@redhat.com> Date: Fri, 16 Dec 2016 12:50:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161206210015.40422-1-jhb@FreeBSD.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-12/txt/msg00321.txt.bz2 On 12/06/2016 09:00 PM, John Baldwin wrote: > The first patch works around an issue where FreeBSD/mips core > dumps from the kernel include an empty ei_flags value in the ELF > header. This causes bfd to select the default MIPS architecture > (bfd_mach_3000) even though it is a 64-bit core file. As a result, > parsing the core dump notes doesn't work correctly since bits_per_word > is 32. It's not clear to me if bfd shouldn't default to a 64-bit > MIPS machine if the ELF header indicates a 64-bit class instead of > this change? > > Changes since the first version are to address most (but perhaps not > all) of the feedback from Luis Machado on patches 2 and 3. The GDB changes are OK (once you've addressed the latest minor nits). Thanks for the patches, and thanks Luis for reviewing this. New targets/hosts deserve a gdb/NEWS entry. Can you write one? Thanks, Pedro Alves