From: Luis Machado <lgustavo@codesourcery.com>
To: John Baldwin <jhb@freebsd.org>, <gdb-patches@sourceware.org>
Cc: <binutils@sourceware.org>
Subject: Re: [PATCH v2 2/3] Add FreeBSD/mips architecture.
Date: Thu, 08 Dec 2016 20:13:00 -0000 [thread overview]
Message-ID: <e818b523-2216-8d7f-dc4b-c5b6795a83e8@codesourcery.com> (raw)
In-Reply-To: <3686876.pSvlj3YOXd@ralph.baldwin.cx>
On 12/08/2016 02:08 PM, John Baldwin wrote:
> On Thursday, December 08, 2016 12:47:42 PM Luis Machado wrote:
>> On 12/06/2016 03:00 PM, John Baldwin wrote:
>>> +static void
>>> +mips_fbsd_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
>>> +{
>>> + enum mips_abi abi = mips_abi (gdbarch);
>>> +
>>> + /* Generic FreeBSD support. */
>>> + fbsd_init_abi (info, gdbarch);
>>> +
>>> + set_gdbarch_software_single_step (gdbarch, mips_software_single_step);
>>> +
>>> + switch (abi)
>>> + {
>>> + case MIPS_ABI_O32:
>>> + tramp_frame_prepend_unwinder (gdbarch, &mips_fbsd_sigframe);
>>> + break;
>>> + case MIPS_ABI_N32:
>>> + break;
>>> + case MIPS_ABI_N64:
>>> + tramp_frame_prepend_unwinder (gdbarch, &mips64_fbsd_sigframe);
>>> + break;
>>> + }
>>> +
>>> + set_gdbarch_iterate_over_regset_sections
>>> + (gdbarch, mips_fbsd_iterate_over_regset_sections);
>>> +
>>> + /* FreeBSD/mips has SVR4-style shared libraries. */
>>> + set_solib_svr4_fetch_link_map_offsets
>>> + (gdbarch, (gdbarch_ptr_bit (gdbarch) == 32 ?
>>> + mips_fbsd_ilp32_fetch_link_map_offsets :
>>> + mips_fbsd_lp64_fetch_link_map_offsets));
>>> +}
>>> +\f
>>> +
>>
>> Do we need to set a reasonable default in case abi is something unknown
>> or undefined? Maybe as a fail-safe?
>
> Default in which sense, for the sigframe unwinder or something else?
> I don't think there's any support in any toolchains I'm aware of to
> generate FreeBSD binaries with other ABIs (no O64 in particular).
>
For the sigframe unwinders. I was mostly concerned about the switch
construct without a default case for something invalid.
next prev parent reply other threads:[~2016-12-08 20:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-06 21:01 [PATCH v2 0/3] Add FreeBSD/mips targets to GDB John Baldwin
2016-12-06 21:01 ` [PATCH v2 3/3] Add native target for FreeBSD/mips John Baldwin
2016-12-08 18:53 ` Luis Machado
2016-12-08 20:09 ` John Baldwin
2016-12-08 20:15 ` Luis Machado
2016-12-06 21:01 ` [PATCH v2 2/3] Add FreeBSD/mips architecture John Baldwin
2016-12-08 18:47 ` Luis Machado
2016-12-08 20:08 ` John Baldwin
2016-12-08 20:13 ` Luis Machado [this message]
2016-12-09 19:02 ` John Baldwin
2016-12-16 12:22 ` GDB attribution policy (Re: [PATCH v2 2/3] Add FreeBSD/mips architecture.) Pedro Alves
2017-01-10 16:19 ` Pedro Alves
2016-12-06 21:01 ` [PATCH v2 1/3] Use the ELF class to determine the word size for FreeBSD core notes John Baldwin
2016-12-13 11:04 ` Nick Clifton
2016-12-23 20:35 ` John Baldwin
2016-12-16 12:50 ` [PATCH v2 0/3] Add FreeBSD/mips targets to GDB Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e818b523-2216-8d7f-dc4b-c5b6795a83e8@codesourcery.com \
--to=lgustavo@codesourcery.com \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=jhb@freebsd.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox