Re: [PATCH v2 3/3] Add native target for FreeBSD/mips.

[Luis Machado <lgustavo@codesourcery.com>]

On 12/06/2016 03:00 PM, John Baldwin wrote:
> This supports the o32 and n64 ABIs.
>
> gdb/ChangeLog:
>
> 	* Makefile.in (ALLDEPFILES): Add mips-fbsd-nat.c.
> 	* config/mips/fbsd.mh: New file.
> 	* configure.host: Add mips*-*-freebsd*.
> 	* mips-fbsd-nat.c: New file.
> ---
>  gdb/ChangeLog           |   7 +++
>  gdb/Makefile.in         |   1 +
>  gdb/config/mips/fbsd.mh |   3 ++
>  gdb/configure.host      |   1 +
>  gdb/mips-fbsd-nat.c     | 141 ++++++++++++++++++++++++++++++++++++++++++++++++
>  5 files changed, 153 insertions(+)
>  create mode 100644 gdb/config/mips/fbsd.mh
>  create mode 100644 gdb/mips-fbsd-nat.c
>
> diff --git a/gdb/ChangeLog b/gdb/ChangeLog
> index 890702e..fc43f81 100644
> --- a/gdb/ChangeLog
> +++ b/gdb/ChangeLog
> @@ -1,5 +1,12 @@
>  2016-12-06  John Baldwin  <jhb@FreeBSD.org>
>
> +	* Makefile.in (ALLDEPFILES): Add mips-fbsd-nat.c.
> +	* config/mips/fbsd.mh: New file.
> +	* configure.host: Add mips*-*-freebsd*.
> +	* mips-fbsd-nat.c: New file.
> +
> +2016-12-06  John Baldwin  <jhb@FreeBSD.org>
> +
>  	* Makefile.in (ALL_TARGET_OBS): Add mips-fbsd-tdep.o.
>  	(ALLDEPFILES): Add mips-fbsd-tdep.c.
>  	* configure.tgt: Add mips*-*-freebsd*.
> diff --git a/gdb/Makefile.in b/gdb/Makefile.in
> index e34fa4a..dee9d73 100644
> --- a/gdb/Makefile.in
> +++ b/gdb/Makefile.in
> @@ -2542,6 +2542,7 @@ ALLDEPFILES = \
>  	microblaze-linux-tdep.c \
>  	microblaze-tdep.c \
>  	mingw-hdep.c \
> +	mips-fbsd-nat.c \
>  	mips-fbsd-tdep.c \
>  	mips-linux-nat.c \
>  	mips-linux-tdep.c \
> diff --git a/gdb/config/mips/fbsd.mh b/gdb/config/mips/fbsd.mh
> new file mode 100644
> index 0000000..f433347
> --- /dev/null
> +++ b/gdb/config/mips/fbsd.mh
> @@ -0,0 +1,3 @@
> +# Host: FreeBSD/mips
> +NATDEPFILES= fork-child.o inf-ptrace.o fbsd-nat.o mips-fbsd-nat.o
> +HAVE_NATIVE_GCORE_HOST = 1

I suppose you tried the gcore command for native GDB on FreeBSD/MIPS and 
it worked fine?

> diff --git a/gdb/configure.host b/gdb/configure.host
> index ef265eb..c45f61d 100644
> --- a/gdb/configure.host
> +++ b/gdb/configure.host
> @@ -129,6 +129,7 @@ m88*-*-openbsd*)	gdb_host=obsd ;;
>  mips*-*-linux*)		gdb_host=linux ;;
>  mips*-*-netbsd* | mips*-*-knetbsd*-gnu)
>  			gdb_host=nbsd ;;
> +mips*-*-freebsd*)	gdb_host=fbsd ;;
>  mips64*-*-openbsd*)	gdb_host=obsd64 ;;
>
>  powerpc-*-aix* | rs6000-*-* | powerpc64-*-aix*)
> diff --git a/gdb/mips-fbsd-nat.c b/gdb/mips-fbsd-nat.c
> new file mode 100644
> index 0000000..ec1dcd8
> --- /dev/null
> +++ b/gdb/mips-fbsd-nat.c
> @@ -0,0 +1,141 @@
> +/* Native-dependent code for FreeBSD/mips.
> +
> +   Copyright (C) 2016 Free Software Foundation, Inc.
> +
> +   This software was developed by SRI International and the University
> +   of Cambridge Computer Laboratory under DARPA/AFRL contract
> +   FA8750-10-C-0237 ("CTSRD"), as part of the DARPA CRASH research
> +   programme.
> +
> +   This file is part of GDB.
> +
> +   This program is free software; you can redistribute it and/or modify
> +   it under the terms of the GNU General Public License as published by
> +   the Free Software Foundation; either version 3 of the License, or
> +   (at your option) any later version.
> +
> +   This program is distributed in the hope that it will be useful,
> +   but WITHOUT ANY WARRANTY; without even the implied warranty of
> +   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +   GNU General Public License for more details.
> +
> +   You should have received a copy of the GNU General Public License
> +   along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
> +
> +#include "defs.h"
> +#include "inferior.h"
> +#include "regcache.h"
> +#include "target.h"
> +
> +#include <sys/types.h>
> +#include <sys/ptrace.h>
> +#include <machine/reg.h>
> +
> +#include "fbsd-nat.h"
> +#include "mips-tdep.h"
> +#include "mips-fbsd-tdep.h"
> +#include "inf-ptrace.h"
> +
> +/* Determine if PT_GETREGS fetches this register.  */
> +
> +static bool
> +getregs_supplies (struct gdbarch *gdbarch, int regnum)
> +{
> +  return ((regnum) >= MIPS_ZERO_REGNUM
> +	  && (regnum) <= gdbarch_pc_regnum (gdbarch));
> +}
> +

Not sure we need the extra ()'s around regnum.

Otherwise i have no further comments on this one.

I'm guessing someone from binutils' side will want to validate 1/3.

Thanks,
Luis