From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 115599 invoked by alias); 13 Dec 2016 11:04:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 115570 invoked by uid 89); 13 Dec 2016 11:04:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.0 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=H*M:5623 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 13 Dec 2016 11:04:43 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 85459BDD4; Tue, 13 Dec 2016 11:04:42 +0000 (UTC) Received: from [10.36.116.213] (ovpn-116-213.ams2.redhat.com [10.36.116.213]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uBDB4e0h027612 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 13 Dec 2016 06:04:41 -0500 Subject: Re: [PATCH v2 1/3] Use the ELF class to determine the word size for FreeBSD core notes. To: John Baldwin , gdb-patches@sourceware.org, binutils@sourceware.org References: <20161206210015.40422-1-jhb@FreeBSD.org> <20161206210015.40422-2-jhb@FreeBSD.org> From: Nick Clifton Message-ID: Date: Tue, 13 Dec 2016 11:04:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20161206210015.40422-2-jhb@FreeBSD.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-12/txt/msg00281.txt.bz2 Hi John, > FreeBSD MIPS64 core dumps contain an empty e_flags value so are assigned > to the default bfd_arch_mips which is 32-bits. I am sorry, but I am worried about this patch breaking things for other, non-MIPS targets. Wouldn't it be easier to update bfd/elfxx-mips.c:_bfd_elf_mips_mach() to test the EI_CLASS field if no flags are set. Maybe by using the ABI_64_P macro ? Cheers Nick