Re: [PATCH v2] RISC-V: Fix disassembly of partial instructions

[Charlie Jenkins <charlie@rivosinc.com>]

On Tue, Dec 24, 2024 at 09:22:06AM +0100, Jan Beulich wrote:
> On 20.12.2024 20:27, Charlie Jenkins wrote:
> > On Fri, Dec 20, 2024 at 11:38:01AM +0100, Jan Beulich wrote:
> >> On 19.12.2024 18:37, Nelson Chu wrote:
> >>> Some minor GNU coding styles as follows.  Also cc Jan and Andrew, hope they
> >>> still have time in their busy schedules can help to see if there are some
> >>> side effects.
> >>
> >> I did actually take a look, but then pretty quickly decided I must be missing
> >> something: There's no disassembly of anything here afaics, and I also can't
> >> see how a partial insn could be disassembled in the first place. Such can
> >> only ever be displayed as raw hex data, I think. And that's what the patch
> > 
> > I think this is just an issue with my terminology. I was referring to
> > raw hex data as the "disassembly". Should the title say "raw hex data"
> > instead of "disassembly"? I was thinking that "disassembly" included
> > any instruction data that was being output from objdump.
> 
> That or "display" instead of "disassembly", if you ask me.

Sounds good, thank you for letting me know. Is there anything beyond
this wording that is of concern in this patch? Unless there is anything
else that needs to be changed, I can send a new version with the same
diff (containing Nelson's comments) but change "disassembly" to
"display" in the title and message.

- Charlie

> 
> Jan