From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id UFTCArfldmeaGQEAWB0awg (envelope-from ) for ; Thu, 02 Jan 2025 14:15:03 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=G63635Tt; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 078F71E097; Thu, 2 Jan 2025 14:15:03 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.3 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B37F51E05C for ; Thu, 2 Jan 2025 14:15:01 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 60A973858CD1 for ; Thu, 2 Jan 2025 19:15:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 60A973858CD1 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=G63635Tt Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by sourceware.org (Postfix) with ESMTPS id 01F243858D1E for ; Thu, 2 Jan 2025 19:14:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 01F243858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 01F243858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::636 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1735845268; cv=none; b=nydUSmnYH1x9qyVHPVOuujVLNy2HDDkv2WVerAVGgxS0jvSobWJn6TeHZBYpSYocwvffZcejl7buM1Mb7DqMe3ZmTOS0YmSFuWkZJMPgDq00SniQSeeX2y3+kNPfQ3LQQUREtFRe7JfG3QEklBmz+o6eIFU9W6w0j/vORuPkpGE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1735845268; c=relaxed/simple; bh=f1lYzi9KoRPVYcF8s7XY+1keGAAZqM7Ir2nEAFMGULU=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=S581SG+73JLrbm5SbKpjTFbqe8RXkhNfsmete4uAJb6Wo4eJpSyU8kUT0zuU//xhrCS9zITMCWZsANdXWv/uN6q99crCbo8YT+DFHnW8uAyxtFSimfQ+V+pp/h+xKmgB7n14vBhcQT5i8XR3xfyOBfn8SmNMb3ZN+c+0O1tP8Ik= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 01F243858D1E Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-21675fd60feso210489715ad.2 for ; Thu, 02 Jan 2025 11:14:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1735845267; x=1736450067; darn=sourceware.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=vfdhXsjTg8UA/T4QPrzDwdwPA7ZZY8++gra3pjEOZdA=; b=G63635TtgV4pvrPcqnDoKuUvs6APQ+m6zzuPBgcSMpw2RWCDTXUTVjeBZLZmzZNFKA WsYZ/9d8AbpHPO47GdXXmuNSvdQJp+173AxlAhrIWvPo6g3eGCAm0ZYbz9ZRakWOlTHe 2eLIEd9Ua4hXvXNtnzoSvlzdTNU0raz2vGGFHX2k8o/AXgYpuV/koVSJWZLVxJ/9qL97 KvfWBVdINMpXnovwZ8lIKtdBKtu8zZ+kY5G9ThXx+9gFx4c9BxqNNEsnhBXu6if5QCnt 7Tw+BE7oDsj2yBUpaPITT7Comee8zua3YghmZEDug/zL63BTHum61jZFQslQDVZCAF7s X3AQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735845267; x=1736450067; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vfdhXsjTg8UA/T4QPrzDwdwPA7ZZY8++gra3pjEOZdA=; b=PFUJCoIN8XxFVQ3FE9+DF8Oat/m8wAOqYOgY0aV/hbHWpV4qUMNAILoDVUEHmzX64u fk4Fy79su6MLke+TthEp2VhnKSYS5GtdHgWpbRKrwtHlWhOL2jnokc5bxgswOnQFKMDa CZ+oZ64KquAM05v55o+junUht5QY3VM5oekJPVB8D/n90PNK3fyAAXaZakwCYRjTzxR4 vs7kjzp2Y9DWtGDr1jZaxGiEeBQcLxpcXBP3/wvHOULpexV8gp7eFQhuJD/SXzfOOtxu JflglvGL3z4Mq2TDUDIXy5WbtgE68xJ6+9vEjR9cF2jSM4yO0NIsUGn5wY5WY+M74tAd sM7g== X-Forwarded-Encrypted: i=1; AJvYcCXklohZt56dd2/FMsKRuqMOgT++8hFXMEpZ9g6GQREaF4uNtGciwNelkoKRRKlewOHW96zHcm3/TJ82qA==@sourceware.org X-Gm-Message-State: AOJu0YwYsd5IBt6LnVA0yvj7XRc6HgPr9W5RoiPRNKRwqWPTcB0o4HVa XJiPW2dASHbIyunmTLSVH9+ig8VgjMx2ytK06zSctNZi2k+ACvipFsxIXuC2yVI= X-Gm-Gg: ASbGncu2Ok4eLoZmDGCwOVUzdJN2WgLVfPcwTQ27TSEE+MM++Pv5LUckUw29RMRzWdQ 0GXnUzwnqcTon4QTZR46CQy1vJFiQTTxM8gf81Fbtxqm3hH8m3qr6aUcB9SmxhvLcn5zNAC1MKD gHLYWsWA6T60ELw6VbFtJwEKeYduub6+zhF3Pf6DMQ9LYxlexqijzYt7q53hS1yIWBYxHcUGdC4 HKT6WwuBnmJCi/Qv2Pk1fyVk5MeQoq2uYBG6dyMoUNGlV0xl99h X-Google-Smtp-Source: AGHT+IF4oUj5JqjDOfT7JPxsHXRVgjg90WpZzHldvCnVfgzAnGnFpwZCBEFgiriKC7rcIdyG2vJw3w== X-Received: by 2002:a05:6a00:4644:b0:728:fab1:eda0 with SMTP id d2e1a72fcca58-72abdebaae0mr61338330b3a.25.1735845265603; Thu, 02 Jan 2025 11:14:25 -0800 (PST) Received: from ghost ([2601:647:6700:64d0:7bc0:c26b:b835:2b01]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72aad8db637sm24693788b3a.119.2025.01.02.11.14.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jan 2025 11:14:24 -0800 (PST) Date: Thu, 2 Jan 2025 11:14:22 -0800 From: Charlie Jenkins To: Jan Beulich Cc: Nelson Chu , jiawei , gdb-patches , Binutils , Andrew Burgess Subject: Re: [PATCH v2] RISC-V: Fix disassembly of partial instructions Message-ID: References: <20241216-fix_objdump_partial_insn-v2-1-8de88a115dbc@rivosinc.com> <2b869ed1-5969-4ac8-890e-5c82f1877543@suse.com> <3bf293a6-63dd-4ee9-9b3c-368c48476513@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3bf293a6-63dd-4ee9-9b3c-368c48476513@suse.com> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Tue, Dec 24, 2024 at 09:22:06AM +0100, Jan Beulich wrote: > On 20.12.2024 20:27, Charlie Jenkins wrote: > > On Fri, Dec 20, 2024 at 11:38:01AM +0100, Jan Beulich wrote: > >> On 19.12.2024 18:37, Nelson Chu wrote: > >>> Some minor GNU coding styles as follows. Also cc Jan and Andrew, hope they > >>> still have time in their busy schedules can help to see if there are some > >>> side effects. > >> > >> I did actually take a look, but then pretty quickly decided I must be missing > >> something: There's no disassembly of anything here afaics, and I also can't > >> see how a partial insn could be disassembled in the first place. Such can > >> only ever be displayed as raw hex data, I think. And that's what the patch > > > > I think this is just an issue with my terminology. I was referring to > > raw hex data as the "disassembly". Should the title say "raw hex data" > > instead of "disassembly"? I was thinking that "disassembly" included > > any instruction data that was being output from objdump. > > That or "display" instead of "disassembly", if you ask me. Sounds good, thank you for letting me know. Is there anything beyond this wording that is of concern in this patch? Unless there is anything else that needs to be changed, I can send a new version with the same diff (containing Nelson's comments) but change "disassembly" to "display" in the title and message. - Charlie > > Jan