From: Jan Beulich <jbeulich@suse.com>
To: "Maciej W. Rozycki" <macro@orcam.me.uk>,
Charlie Jenkins <charlie@rivosinc.com>
Cc: Nelson Chu <nelson@rivosinc.com>, jiawei <jiawei@iscas.ac.cn>,
gdb-patches <gdb-patches@sourceware.org>,
Binutils <binutils@sourceware.org>,
Andrew Burgess <aburgess@redhat.com>
Subject: Re: [PATCH v2] RISC-V: Fix disassembly of partial instructions
Date: Mon, 6 Jan 2025 09:22:32 +0100 [thread overview]
Message-ID: <80fef3c6-ebcf-4162-90c6-c5d5b169dec7@suse.com> (raw)
In-Reply-To: <alpine.DEB.2.21.2501030616370.49841@angie.orcam.me.uk>
On 03.01.2025 07:22, Maciej W. Rozycki wrote:
> On Thu, 2 Jan 2025, Charlie Jenkins wrote:
>
>>> That or "display" instead of "disassembly", if you ask me.
>>
>> Sounds good, thank you for letting me know. Is there anything beyond
>> this wording that is of concern in this patch? Unless there is anything
>> else that needs to be changed, I can send a new version with the same
>> diff (containing Nelson's comments) but change "disassembly" to
>> "display" in the title and message.
>
> I think relevant test cases need to be added to the testsuite, I guess
> under binutils/testsuite/binutils-all/riscv/ as this covers `objdump'
> rather than any of the other tools. This is to guarantee things won't
> regress again by accident.
As to a testcase: Yes. As to where to put it: Almost all disassembler
tests really live in the gas testsuite, afaict.
Jan
next prev parent reply other threads:[~2025-01-06 8:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-16 22:23 Charlie Jenkins
2024-12-19 17:37 ` Nelson Chu
2024-12-19 18:37 ` Charlie Jenkins
2024-12-20 10:38 ` Jan Beulich
2024-12-20 19:27 ` Charlie Jenkins
2024-12-24 8:22 ` Jan Beulich
2025-01-02 19:14 ` Charlie Jenkins
2025-01-03 6:22 ` Maciej W. Rozycki
2025-01-03 19:23 ` Charlie Jenkins
2025-01-06 8:22 ` Jan Beulich [this message]
2025-01-06 10:30 ` Andrew Burgess
2025-01-09 2:14 ` Nelson Chu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80fef3c6-ebcf-4162-90c6-c5d5b169dec7@suse.com \
--to=jbeulich@suse.com \
--cc=aburgess@redhat.com \
--cc=binutils@sourceware.org \
--cc=charlie@rivosinc.com \
--cc=gdb-patches@sourceware.org \
--cc=jiawei@iscas.ac.cn \
--cc=macro@orcam.me.uk \
--cc=nelson@rivosinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox