From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id u3iAOROTe2c88AQAWB0awg (envelope-from ) for ; Mon, 06 Jan 2025 03:23:47 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=suse.com header.i=@suse.com header.a=rsa-sha256 header.s=google header.b=WGjARYfv; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id E31721E097; Mon, 6 Jan 2025 03:23:47 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8CE8C1E091 for ; Mon, 6 Jan 2025 03:23:47 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 30E4F3858408 for ; Mon, 6 Jan 2025 08:23:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 30E4F3858408 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=suse.com header.i=@suse.com header.a=rsa-sha256 header.s=google header.b=WGjARYfv Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by sourceware.org (Postfix) with ESMTPS id A70483858D21 for ; Mon, 6 Jan 2025 08:22:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A70483858D21 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A70483858D21 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::431 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736151746; cv=none; b=tJJlAt6akg5gZQCvl/K0kHBsV3sZFs2UUOiauPOfxIS+2r43McpVw5eZVuuVe8TBWUepyPWu1Ua2Si1MxZ7qcmIDfcoDG+97Ha/k/g0ylzLWWvVHZEZZB2Bv/sS86BFQnqh0CBbBbU13O8uGg/s6l1Q+EQLgHt9NEEuPAgbSTwQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736151746; c=relaxed/simple; bh=c7/ENqSS7Vtw2Abnl0I55lasAZ4gjY2i32752Y78tLM=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=xod3sKkeOzsoSJ4Wi66ZPxV2vSMW1T5VnpH9nxIaLSyK4HxkvG44eBMw5vvugOwWkDgv0WInKhwFjucvDtR/HdPUgc9e6Rg2ZvhmDcsZTijTndbhbS33XNJutnjLdzHOASIPm8CvARfE7y4PJ9dgrrc8cWbWXopzHUQmpP4c3PY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A70483858D21 Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-385d7b4da2bso11936971f8f.1 for ; Mon, 06 Jan 2025 00:22:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1736151745; x=1736756545; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=0UvYTAVdizgb8uA/M2dBtQILjkaX6IMuYPwmuOcyWDc=; b=WGjARYfvsMu/j579wIUNB57oSc2DJHpSrXAFkqQwWtyjgpn1DhmDL7/iZ5dZsa+gF0 50hSxw/sT6tbdBekLhs4tuNEtBVH5200cf5GUQgbeHMyEE/7Ow+iy76IiBSFSQ4j2Z9w xdKJ9vpbkVjADeNfkOUCzctL7VObH16TvPl+A1k++HbInFrIDLU8dR+yH0q+ZiKTuBzE MmiQ2ltoogbZ2ZQlgrObCPnBmeg2zaXHk/Oc2DByS0Pzf/Qo1DUW1wOlhXLCefHVPBO/ HetuBAOsfDUCivNsd9wpTUUVg9mxgpR1kvvDc6HTgxwt7L/MALr5HyIXc6Y39hG5+FDK VdDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736151745; x=1736756545; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0UvYTAVdizgb8uA/M2dBtQILjkaX6IMuYPwmuOcyWDc=; b=Aa/ckoALW2cctWS3/KFOho1es3cKTzNRvc/xA0gjlNMiuqTiDuF/VJ1xpf5ib4QeIL ZyioeYcRurSGqi+smb51NJERuqzhjFSmU/DivoIokEMDmcBaLwsPPb35AYbzjf9/qQIo y2AQkqBf2jROEr0uvsLXDQgZKsLuoY5s+yv9BoE6oEXldpTm3Pwrt7YsNDuHe4Apjddc d7cM649HueV8PTniYdQ8vbjFqtiL5OGXoFWGbSvgaYPRB4Gnc/z4VuTcQfUeBaB0A5WV lYFG8oiQ/X+TjjoUfdGctqM/Snmq5ohW7QNbVy/1hbfeEpe/nxGbVPSyOjJjH9fy4cAJ q9dA== X-Forwarded-Encrypted: i=1; AJvYcCVAMjF9kyZcK+z5f2EvA2vErxpu1nODFn+m5G25xhquZTrLYu6CChMc6e0hkj05LD1shAWPF1f/xn+DxQ==@sourceware.org X-Gm-Message-State: AOJu0Yx35yIEvi+fM3J+NX7w3ewGn5n/F8zt+6O/VnNYVlnsXcNTK1rM XrD7Bas8/82nKmcNfkCAaWWOhd0wB8Rrnd9XUaNaG5bme2kp5b2pWMH/0zeu9w== X-Gm-Gg: ASbGncua2m4NNh1+i34meggh75qoZJscGKqCtsDgEhAIY2jlscVQiPvS8vjZGikJ5tv 1Uk0GwSpzx/QFDfi9NiYU0auV0IJqVBUhVDKWPO6oAo8BXJ+4iFu8zw+BDhSJzWY01iS807ECRa PKdVgRlywOmYjZ+epZanD6MTEakzsmq+j61QVW7DQT0+6fGSKcrvLPYmOIQRYe+8mDpzyKyEklH xGhZRJOGjT7xfUX7PIMz6/D1PzGjKDR1Y+WP0mMxPdLSWhcY/m0QfoeRkR87YoDjte0n1jU7pu9 1BdZ6jMHkI4OcYSrO5IwPsMDptjh3KHuOVDF6WZ9lQ== X-Google-Smtp-Source: AGHT+IF8ms+OmUeH1kqpPc/tG7vHNj8v5TtiBQmCPa0csxAvXsGwZnMzFhd9jCACvGjXIiCV0X+7uw== X-Received: by 2002:a05:6000:1acb:b0:386:3213:5ba1 with SMTP id ffacd0b85a97d-38a221f2fbdmr47348950f8f.24.1736151745370; Mon, 06 Jan 2025 00:22:25 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a1c89e1c0sm48091274f8f.77.2025.01.06.00.22.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Jan 2025 00:22:25 -0800 (PST) Message-ID: <80fef3c6-ebcf-4162-90c6-c5d5b169dec7@suse.com> Date: Mon, 6 Jan 2025 09:22:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] RISC-V: Fix disassembly of partial instructions To: "Maciej W. Rozycki" , Charlie Jenkins Cc: Nelson Chu , jiawei , gdb-patches , Binutils , Andrew Burgess References: <20241216-fix_objdump_partial_insn-v2-1-8de88a115dbc@rivosinc.com> <2b869ed1-5969-4ac8-890e-5c82f1877543@suse.com> <3bf293a6-63dd-4ee9-9b3c-368c48476513@suse.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 03.01.2025 07:22, Maciej W. Rozycki wrote: > On Thu, 2 Jan 2025, Charlie Jenkins wrote: > >>> That or "display" instead of "disassembly", if you ask me. >> >> Sounds good, thank you for letting me know. Is there anything beyond >> this wording that is of concern in this patch? Unless there is anything >> else that needs to be changed, I can send a new version with the same >> diff (containing Nelson's comments) but change "disassembly" to >> "display" in the title and message. > > I think relevant test cases need to be added to the testsuite, I guess > under binutils/testsuite/binutils-all/riscv/ as this covers `objdump' > rather than any of the other tools. This is to guarantee things won't > regress again by accident. As to a testcase: Yes. As to where to put it: Almost all disassembler tests really live in the gas testsuite, afaict. Jan