From: Jan Beulich <jbeulich@suse.com>
To: Nelson Chu <nelson@rivosinc.com>
Cc: jiawei <jiawei@iscas.ac.cn>,
gdb-patches <gdb-patches@sourceware.org>,
Binutils <binutils@sourceware.org>,
Andrew Burgess <aburgess@redhat.com>,
Charlie Jenkins <charlie@rivosinc.com>
Subject: Re: [PATCH v2] RISC-V: Fix disassembly of partial instructions
Date: Fri, 20 Dec 2024 11:38:01 +0100 [thread overview]
Message-ID: <2b869ed1-5969-4ac8-890e-5c82f1877543@suse.com> (raw)
In-Reply-To: <CAPpQWtCd4jBFEEiB4=2HLTjXPMPQe4kyquftdRSjikk28uFw_w@mail.gmail.com>
On 19.12.2024 18:37, Nelson Chu wrote:
> Some minor GNU coding styles as follows. Also cc Jan and Andrew, hope they
> still have time in their busy schedules can help to see if there are some
> side effects.
I did actually take a look, but then pretty quickly decided I must be missing
something: There's no disassembly of anything here afaics, and I also can't
see how a partial insn could be disassembled in the first place. Such can
only ever be displayed as raw hex data, I think. And that's what the patch
appears to be doing, just that it's description says otherwise. That plus the
lack of a testcase demonstrating the intended behavior made me simply stop
any effort here.
Jan
next prev parent reply other threads:[~2024-12-20 10:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-16 22:23 Charlie Jenkins
2024-12-19 17:37 ` Nelson Chu
2024-12-19 18:37 ` Charlie Jenkins
2024-12-20 10:38 ` Jan Beulich [this message]
2024-12-20 19:27 ` Charlie Jenkins
2024-12-24 8:22 ` Jan Beulich
2025-01-02 19:14 ` Charlie Jenkins
2025-01-03 6:22 ` Maciej W. Rozycki
2025-01-03 19:23 ` Charlie Jenkins
2025-01-06 8:22 ` Jan Beulich
2025-01-06 10:30 ` Andrew Burgess
2025-01-09 2:14 ` Nelson Chu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b869ed1-5969-4ac8-890e-5c82f1877543@suse.com \
--to=jbeulich@suse.com \
--cc=aburgess@redhat.com \
--cc=binutils@sourceware.org \
--cc=charlie@rivosinc.com \
--cc=gdb-patches@sourceware.org \
--cc=jiawei@iscas.ac.cn \
--cc=nelson@rivosinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox