From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ksteG5JJZWeceiQAWB0awg (envelope-from ) for ; Fri, 20 Dec 2024 05:40:18 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=suse.com header.i=@suse.com header.a=rsa-sha256 header.s=google header.b=a46QRN/u; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 66B641E097; Fri, 20 Dec 2024 05:40:18 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E86131E05C for ; Fri, 20 Dec 2024 05:40:17 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 71E063858C52 for ; Fri, 20 Dec 2024 10:40:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 71E063858C52 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=suse.com header.i=@suse.com header.a=rsa-sha256 header.s=google header.b=a46QRN/u Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by sourceware.org (Postfix) with ESMTPS id 7B6593858D37 for ; Fri, 20 Dec 2024 10:38:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7B6593858D37 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7B6593858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::431 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1734691084; cv=none; b=Y3hkh5U0xgSZXIMh/Nr8w04u5jSmQYRqwNiD5GV8n1HcJuB/QhdoDLGnh7erg+A/3lWybff5+ZT+XOIAxFC/uPHVc/MefxmYHRj5nLfprBHyWStGt/TcSGby+UmChwBLzNr2MH8S6Tb+Rd/0+tp0RnYnhECrD91Q8GVHeGLIDiI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1734691084; c=relaxed/simple; bh=v/JJJr4mVKDHYZOB1B+k2RPIOPQB21k6R/IfpbwgI9c=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=PuwfRtA/BKpxikJGab7hqbV4vLI6A0Oe/yZ8wAEaitKsv4/f8kkWRNKQshFfZe9aAQ9+arDHcIzTccirmIQOse7gh2LudWa83qV9GMvHptrBsEs2ljAUjMILH0sObVvWxgMyyVYUqleVC9KkryRbHUNwWK6ZIv6zIi+XjwcBAnc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7B6593858D37 Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-38633b5dbcfso1667372f8f.2 for ; Fri, 20 Dec 2024 02:38:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1734691083; x=1735295883; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=cdPdrMeiHqoOiAvH2W1aQZNC4RVZU8USHiQmwcH618A=; b=a46QRN/ukxgXS/KSIbaNG80EC6zhW8ga5Fhv6+HPdkBO5WQoeszZf2nvF3wPHk6TC6 8q+3ASSLsNFPqKaAeBckIzgA1ljDO/q5bsP0RibbXRawRjVH4cn4yY9utheLrvsCiomo ji7sXLzHEFKkjAQKjIrXG3l/zQMYRI+WoFsl6/WrbOuQccgAXN95YNFS4ylFmR5KuSsl bYdUc+nWuh+g4G7xrpS4yuohFWNs85bLoeeuygxMWUK0S0hK1u+RCZsUosiVE8bmJOD5 GwpklR90D5nxhDJRSrzBPd1uz4RIlfthQ9SXvT2Gh0YnWhVEgwRgIXD084nh724/5ah/ wSRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734691083; x=1735295883; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cdPdrMeiHqoOiAvH2W1aQZNC4RVZU8USHiQmwcH618A=; b=UraXWQk6eI8KDrebam5AzN2T4ZGNHgPx3TWxB/eHzMrPDxXSUpxFa0n9FHEGGNPhBe FSUsIjDnGZ91GzJ77SK0XpND6/qh9T0khISO7e/uwQb59Cc8AcswIRuYip/FIzWAG/Hi ODHb6AtG/UGLuRumakQSftEJLfpR9+3bvKadL2NxPdge3m7FqoAMBg1pnMEPMq8EAUXn d5PvlrfhRZb9w0wSQ948TcMhlz7i0sEjF9g74ZKppzZylIGQ7qsxRUk8rnsNV5/YYxsv 4b8zJKWNj295ORQdKw8JXlZTtQpJgDUI3b47WalHrMT20mApCJBbxq7Gt0hzaE1rhjYu L1sQ== X-Forwarded-Encrypted: i=1; AJvYcCUIfnCnPQrqHxV9pxyayalDS3Q3HSNIedPUZpjx2XHjX0NcJ4LHtUfg5P6y38fV4jwejyR6QDpD98dQPg==@sourceware.org X-Gm-Message-State: AOJu0Yymq4fwrAp23D3kSwsHeL1kzLXDDYKIeJiwQ0h/zGm9VS6qhhGe iX9uv2Z1EgEXsImujD+gS/GJiknalZ46mytCMczMP2nP6Gb9H+3AfbrUajn/ug== X-Gm-Gg: ASbGncvdIhUO6RFltb7faVZTea6giJ6FcH9IpkpqlILQohzV20EpPWDY1TqaZDVmq2u 2lQUGBJjfAFPZ9lC+B3+srsYjWn8klTm4x/9FGjOEtG2a3uJ/rJ1anPdev8g45JHH4X1HZsyBvX jPKuskgi0tzAvog0fY/ZCr6CjpxZr43RKJG2oW1CRteKe1WoAV6Ls020MY7hQJpVm9Pbjr2VNWG ZRIn7ojs0m/4mlpfsQP11eTQH5B27IPSFHcRhKp1xtLerv76wEeGvBzXlZ0bKst8dP8I7O6CC/Z UG1Zm4FHXgI1AaZcjt4P6KHgZqT5DYi3AGeCjvejxg== X-Google-Smtp-Source: AGHT+IGcy63AFe0WfNMBbJYL0TArQnZjsJmyZdaAhWzt9bWyIEpouoUiWyeuPq2h5NHUJJr4ZJtOIw== X-Received: by 2002:a05:6000:178c:b0:385:f17b:de5a with SMTP id ffacd0b85a97d-38a221f316cmr2586214f8f.28.1734691083157; Fri, 20 Dec 2024 02:38:03 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a1c89e1acsm3718463f8f.68.2024.12.20.02.38.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Dec 2024 02:38:02 -0800 (PST) Message-ID: <2b869ed1-5969-4ac8-890e-5c82f1877543@suse.com> Date: Fri, 20 Dec 2024 11:38:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] RISC-V: Fix disassembly of partial instructions To: Nelson Chu Cc: jiawei , gdb-patches , Binutils , Andrew Burgess , Charlie Jenkins References: <20241216-fix_objdump_partial_insn-v2-1-8de88a115dbc@rivosinc.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 19.12.2024 18:37, Nelson Chu wrote: > Some minor GNU coding styles as follows. Also cc Jan and Andrew, hope they > still have time in their busy schedules can help to see if there are some > side effects. I did actually take a look, but then pretty quickly decided I must be missing something: There's no disassembly of anything here afaics, and I also can't see how a partial insn could be disassembled in the first place. Such can only ever be displayed as raw hex data, I think. And that's what the patch appears to be doing, just that it's description says otherwise. That plus the lack of a testcase demonstrating the intended behavior made me simply stop any effort here. Jan