Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Burgess <aburgess@redhat.com>
To: Nelson Chu <nelson@rivosinc.com>, Charlie Jenkins <charlie@rivosinc.com>
Cc: jiawei <jiawei@iscas.ac.cn>,
	gdb-patches <gdb-patches@sourceware.org>,
	Binutils <binutils@sourceware.org>,
	Jan Beulich <jbeulich@suse.com>
Subject: Re: [PATCH v2] RISC-V: Fix disassembly of partial instructions
Date: Mon, 06 Jan 2025 10:30:56 +0000	[thread overview]
Message-ID: <87h66c2pzz.fsf@redhat.com> (raw)
In-Reply-To: <CAPpQWtCd4jBFEEiB4=2HLTjXPMPQe4kyquftdRSjikk28uFw_w@mail.gmail.com>

Nelson Chu <nelson@rivosinc.com> writes:

> Some minor GNU coding styles as follows.  Also cc Jan and Andrew, hope they
> still have time in their busy schedules can help to see if there are some
> side effects.

I caught up on this thread today.  All the suggestions seem like good
advice to me.  But I have no issues with the underlying fix, it seems
like a good improvement to me.

Acked-By: Andrew Burgess <aburgess@redhat.com>

Thanks,
Andrew


  parent reply	other threads:[~2025-01-06 10:31 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-16 22:23 Charlie Jenkins
2024-12-19 17:37 ` Nelson Chu
2024-12-19 18:37   ` Charlie Jenkins
2024-12-20 10:38   ` Jan Beulich
2024-12-20 19:27     ` Charlie Jenkins
2024-12-24  8:22       ` Jan Beulich
2025-01-02 19:14         ` Charlie Jenkins
2025-01-03  6:22           ` Maciej W. Rozycki
2025-01-03 19:23             ` Charlie Jenkins
2025-01-06  8:22             ` Jan Beulich
2025-01-06 10:30   ` Andrew Burgess [this message]
2025-01-09  2:14     ` Nelson Chu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h66c2pzz.fsf@redhat.com \
    --to=aburgess@redhat.com \
    --cc=binutils@sourceware.org \
    --cc=charlie@rivosinc.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jbeulich@suse.com \
    --cc=jiawei@iscas.ac.cn \
    --cc=nelson@rivosinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox