From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id WBYHOvmwe2eCBQUAWB0awg (envelope-from ) for ; Mon, 06 Jan 2025 05:31:21 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=CnXULroE; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id EA4651E097; Mon, 6 Jan 2025 05:31:21 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A09041E05C for ; Mon, 6 Jan 2025 05:31:21 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 67CC9385840B for ; Mon, 6 Jan 2025 10:31:21 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id A9E8D3858D21 for ; Mon, 6 Jan 2025 10:31:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A9E8D3858D21 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A9E8D3858D21 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736159460; cv=none; b=VALZi+dqjjbcPJ+kyttErzzVE5j/c4gyv5F5JtQNRQ45lmBalAuhvGQN8om3nK7SpN78PZCWNRL5mJkd4VsZYQ7dmIjDGm7p2xtkUxcPn/zKbloofPNiZ1QVuOupGcoQUKfhnUrLUgNgIA+UIrGe4ITjeP8i9qi2GdUnpSg7FMk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736159460; c=relaxed/simple; bh=qsJxkLXu4udwr4tkV6nOBXa7P2M1srE51Sdi8xc9s5M=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=xsE2zJmMoWjuoE6lxM11jGnPuIpPCI6j9zB1HSWhJpVCs6nzde8YmQFxZ80ahYk94hPhba1zWnOfEAETmsKyVMvsIsWX1fdhz0R+37x0GivGK5W9yvaLNFHpYva/LtUv6DzJswPxc3uB/7zrzbhDxY19NYCtp44XjcRTDgUSBaQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A9E8D3858D21 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=CnXULroE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736159460; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HbAGbzBQZYEkWod1rOD7mxIwatJEppP9rj1knFOY9qI=; b=CnXULroEppbaOLqwORDBtCRS48jGVGTznzdlifNjPmpk9qPDsp0Vlwqnn7IoNbE3CIUl8t ooZcm9RXlsbt0H5jAZNn/gviGeheD6Mtt2R3jkqRMAajpJn29OzXk5YdT7IChDHX1e3k9B XYu2cmhkeCMDO1JL2Jv8igLM6N/lM5U= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-596-05McRWlBMtKu_1YQVW2UIg-1; Mon, 06 Jan 2025 05:30:59 -0500 X-MC-Unique: 05McRWlBMtKu_1YQVW2UIg-1 X-Mimecast-MFC-AGG-ID: 05McRWlBMtKu_1YQVW2UIg Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-436723db6c4so80844285e9.3 for ; Mon, 06 Jan 2025 02:30:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736159458; x=1736764258; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HbAGbzBQZYEkWod1rOD7mxIwatJEppP9rj1knFOY9qI=; b=wJpJMy8ubD7zoDaG0SHU44xQR8EUk8p0JYyE29I2KvIaLjkEuZQZWxk4w9a/Veu/ec +UBr2zNWXNGPGgqclos8IlVdl9JA7k0N3t4TS+cKyf544kxGRjYT+9iw4/LxkYTN1Xg1 9NyXo9vrEC3x7UphsUIwecQbcOSIE+GnUVW3oR4pbk4FCRJscWcM5ENDL0ByJsNFJgxt HEIC6ZLfmddo9eW3/WiZvIE5T5TY4Gp4D+6ktQpisHQ0aL9vzVErwjbVuEBQLrg/DsFu aMhZpUtUOVNpoU5MWOgGagU9mJqkzFqsqbcd7d8mUvSJQHqKNevtj5zIMjfiK4NclYVd ezlQ== X-Forwarded-Encrypted: i=1; AJvYcCX5aUrElGRJZyOc4enM/y0LiYVV5kNjMja4U7nfQX/Pth2N60jKQpGhaMUDTB8j5g8dnX75/ZlS41Si9g==@sourceware.org X-Gm-Message-State: AOJu0Yzylk0In8jvM8LGpB708EE9KiIyJKAGGL0nS24UxbzP7JGTo4KC UD3PFQotN9OmwIdH2qNkOtyjKIGbTy6O5P2t1L7OIzDtiTRH5sA2+nlrKfkFJiWzzmCgCy594zp EHW5KsFoduNLfbbMgd24u3bH6V71YvXHq6ffFdoubpKoIuArsuOW9waLdi7M= X-Gm-Gg: ASbGnctJFR5hjYex9ue7JA0DJx+A6HQX1dRlzn/dBhKcTFSg6sti1EMMZIQAmOBHxvB im5oFWsLrsUXZ2J/YkIBh25gvSOVYUSRepzR00f+4S8P5PTpydasL0UhmpoLLt/MNlnN7cgGaAY FshBElZRA+iVHSmQ9dby31M+MDNANgyDxds03I11/kc9C+Eqxi8cwkAZC6d7mFgo1iLIYMuPUVT qYc6vTJDr6ElZgpsH4+FZJqRcQAuiTunB4bc3nXAFVM8jn4G28wM4rUI3VgX5wjDl3IDJcv3bsJ bfTXG7OF X-Received: by 2002:a05:600c:3106:b0:434:a802:43d with SMTP id 5b1f17b1804b1-43668b93817mr465809905e9.27.1736159457975; Mon, 06 Jan 2025 02:30:57 -0800 (PST) X-Google-Smtp-Source: AGHT+IEZ+s00u3jkfJkXeiG2IYd1jM3M20FU5vZuaYmAddSwI1gTDt258jtWQNsv2Jgw6PcmBQ4HZA== X-Received: by 2002:a05:600c:3106:b0:434:a802:43d with SMTP id 5b1f17b1804b1-43668b93817mr465809715e9.27.1736159457661; Mon, 06 Jan 2025 02:30:57 -0800 (PST) Received: from localhost (248.209.200.146.dyn.plus.net. [146.200.209.248]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43656b4471bsm597699105e9.44.2025.01.06.02.30.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jan 2025 02:30:57 -0800 (PST) From: Andrew Burgess To: Nelson Chu , Charlie Jenkins Cc: jiawei , gdb-patches , Binutils , Jan Beulich Subject: Re: [PATCH v2] RISC-V: Fix disassembly of partial instructions In-Reply-To: References: <20241216-fix_objdump_partial_insn-v2-1-8de88a115dbc@rivosinc.com> Date: Mon, 06 Jan 2025 10:30:56 +0000 Message-ID: <87h66c2pzz.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ofLm5_N-quL0qxBsJj5kf5zpRA-GHNELmvYxbS4_5N0_1736159458 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Nelson Chu writes: > Some minor GNU coding styles as follows. Also cc Jan and Andrew, hope they > still have time in their busy schedules can help to see if there are some > side effects. I caught up on this thread today. All the suggestions seem like good advice to me. But I have no issues with the underlying fix, it seems like a good improvement to me. Acked-By: Andrew Burgess Thanks, Andrew