RE: [PATCH 04/12] gdb: Sync up x86-gcc-cpuid.h with cpuid.h from gcc 14 branch.

["Schimpe, Christina" <christina.schimpe@intel.com>]

> -----Original Message-----
> From: Thiago Jung Bauermann <thiago.bauermann@linaro.org>
> Sent: Thursday, February 6, 2025 4:04 AM
> To: Schimpe, Christina <christina.schimpe@intel.com>
> Cc: gdb-patches@sourceware.org
> Subject: Re: [PATCH 04/12] gdb: Sync up x86-gcc-cpuid.h with cpuid.h from gcc 14
> branch.
> 
> 
> "Schimpe, Christina" <christina.schimpe@intel.com> writes:
> 
> > This is required for a later commit which requires "bit_SHSTK".
> > ---
> >  gdb/nat/x86-gcc-cpuid.h | 153
> > ++++++++++++++++++++++++++++++++--------
> >  1 file changed, 122 insertions(+), 31 deletions(-)
> 
> Reviewed-by: Thiago Jung Bauermann <thiago.bauermann@linaro.org>
> 
> > diff --git a/gdb/nat/x86-gcc-cpuid.h b/gdb/nat/x86-gcc-cpuid.h index
> > b0f2d239af3..a571eb8a734 100644
> > --- a/gdb/nat/x86-gcc-cpuid.h
> > +++ b/gdb/nat/x86-gcc-cpuid.h
> > @@ -1,5 +1,5 @@
> >  /*
> > - * Helper cpuid.h file copied from gcc-6.0.0.  Code in gdb should not
> > + * Helper cpuid.h file copied from gcc-14-2-0.  Code in gdb should
> > + not
> >   * include this directly, but pull in x86-cpuid.h and use that func.
> >   */
> 
> Incredibly nitty nit: any particular reason for changing from dot-separated version
> number to dash-separated?

No, I'll change it to dot-separated again for the next version. 

Thanks!
Christina
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928