RE: [PING^2][PATCH v5 00/13] Add new command to print the shadow stack backtrace

["Joos, Christina" <christina.joos@intel.com>]

> -----Original Message-----
> From: Thiago Jung Bauermann <thiago.bauermann@linaro.org>
> Sent: Donnerstag, 15. Oktober 2026 20:14
> To: Joos, Christina <christina.joos@intel.com>
> Cc: gdb-patches@sourceware.org; tom@tromey.com;
> luis.machado.foss@gmail.com
> Subject: Re: [PING][PATCH v5 00/13] Add new command to print the shadow
> stack backtrace
> 
> "Joos, Christina" <christina.joos@intel.com> writes:
> 
> >> -----Original Message-----
> >> From: Christina Joos <christina.joos@intel.com>
> >> Sent: Donnerstag, 24. September 2026 10:33
> >> To: gdb-patches@sourceware.org
> >> Cc: thiago.bauermann@linaro.org; tom@tromey.com;
> >> luis.machado.foss@gmail.com
> >> Subject: [PATCH v5 00/13] Add new command to print the shadow stack
> >> backtrace
> >>
> >> Hi all,
> >>
> >> this is v5 of the series
> >> "Add new command to print the shadow stack backtrace".
> >>
> >> This version addresses the feedback from Luis and Thiago.
> >> Some parts of this series are already approved, but for some patches
> >> I still need approval from the global maintainers before I can merge this.
> >
> > Kindly pinging for feedback!
> 
> Just to be explicit about it, from my side the patch series looks good.

Thanks a lot for your reviews and approvals!

> It does need review/approval for the generic code.

I was just about to ping on this one more time, so ... kindly pinging for feedback!😊

This is an overview about the current review state; those patches still need approval (generic code):

01: gdb: Generalize handling of the shadow stack pointer
=> Approved for the aarch64 parts but still needs an approval for the generic code.
03: gdb: Add get_main_func_start_pc to refactor frame.c:inside_main_func.
08: gdb: Add command option 'bt -shadow' to print the shadow stack backtrace.
09: gdb: Provide gdbarch hook to distinguish shadow stack backtrace elements.  
11: gdb: Enable inferior calls in the shadow stack backtrace.
12: gdb: Enable signal trampolines in the shadow stack backtrace.
13: gdb, mi: Add -shadow-stack-list-frames command

Already approved by Tom or Thiago:
02: aarch64: Implement gdbarch function top_addr_empty_shadow_stack.
04: gdb: Refactor 'stack.c:print_frame'.
05: gdb: Introduce 'stack.c:print_pc' function without frame argument.
06: gdb: Refactor 'find_symbol_funname' and 'info_frame_command_core' in stack.c.
07: gdb: Refactor 'stack.c:print_frame_info'.

This one I may self-approve, but any feedback/reviews are more than welcome:
10: gdb: Implement the hook 'is_no_return_shadow_stack_address' for amd64 linux.  

The docs part is Reviewed-By Eli.

Kind Regards,
Christina

________________________________________
Intel Deutschland GmbH 

Registered Address: Dornacher Strasse 1, 85622 Feldkirchen, Germany 

Tel: +49 (89) 99143-0 

www.intel.de 

Managing Directors: Candice Moore, Jeffrey Schneiderman, Ramachandran Sitaraman

Chairperson of the Supervisory Board: Sonja Pierer

Registered Seat: Munich Commercial Register B: Amtsgericht Munich HRB 186928

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.