From: Thiago Jung Bauermann <thiago.bauermann@linaro.org>
To: Christina Joos <christina.joos@intel.com>
Cc: gdb-patches@sourceware.org, tom@tromey.com,
luis.machado.foss@gmail.com
Subject: Re: [PATCH v5 01/13] gdb: Generalize handling of the shadow stack pointer.
Date: Thu, 24 Sep 2026 21:03:14 +0000 [thread overview]
Message-ID: <87ld8ql5v1.fsf@linaro.org> (raw)
In-Reply-To: <20260924083311.1961530-2-christina.joos@intel.com>
Hello Christina,
Thank you for this new version. Everything looks good to me.
Christina Joos <christina.joos@intel.com> writes:
> Until now, handling of the shadow stack pointer has been done in the
> target dependent implementations of the gdbarch hook
> 'gdbarch_shadow_stack_push'. Also amd64 and aarch64 linux specific
> unwinders for the shadow stack pointer are implemented.
> In a following patch a command line option "-shadow" will be added to
> the backtrace command to print the shadow stack backtrace. This requires
> more target-independent logic to handle the shadow stack pointer. To
> avoid that we duplicate the logic, add new source and header files
> "shadow-stack" for the implementation of shadow_stack_push and shadow
> stack pointer unwinding in a target-independent way. Since the
> conditions for an empty shadow stack differ betweens ARM's GCS and CET
> shadow stack this further requires a new gdbarch hook
> gdbarch_top_addr_empty_shadow_stack to unwind the previous shadow stack
> pointer. The ARM specific implementation for
> gdbarch_top_addr_empty_shadow_stack will added in the following commit:
> "aarch64: Implement gdbarch function top_addr_empty_shadow_stack.".
>
> Reviewed-By: Tom Tromey <tom@tromey.com>
> Reviewed-by: Thiago Jung Bauermann <thiago.bauermann@linaro.org>
The Reviewed-by above is for the generic code. For the aarch64 part:
Approved-by: Thiago Jung Bauermann <thiago.bauermann@linaro.org> (aarch64)
> ---
> gdb/Makefile.in | 2 +
> gdb/aarch64-tdep.c | 54 +++----------
> gdb/amd64-linux-tdep.c | 134 +++----------------------------
> gdb/amd64-tdep.c | 22 +++++
> gdb/gdbarch-gen.c | 126 +++++++++++++++++++++++------
> gdb/gdbarch-gen.h | 63 +++++++++++----
> gdb/gdbarch_components.py | 84 +++++++++++++++----
> gdb/infcall.c | 4 +-
> gdb/linux-tdep.c | 9 ++-
> gdb/shadow-stack.c | 164 ++++++++++++++++++++++++++++++++++++++
> gdb/shadow-stack.h | 42 ++++++++++
> 11 files changed, 477 insertions(+), 227 deletions(-)
> create mode 100644 gdb/shadow-stack.c
> create mode 100644 gdb/shadow-stack.h
--
Thiago
(he/him)
next prev parent reply other threads:[~2026-09-24 21:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-24 8:32 [PATCH v5 00/13] Add new command to print the shadow stack backtrace Christina Joos
2026-09-24 8:32 ` [PATCH v5 01/13] gdb: Generalize handling of the shadow stack pointer Christina Joos
2026-09-24 21:03 ` Thiago Jung Bauermann [this message]
2026-09-24 8:32 ` [PATCH v5 02/13] aarch64: Implement gdbarch function top_addr_empty_shadow_stack Christina Joos
2026-09-24 21:04 ` Thiago Jung Bauermann
2026-09-24 8:33 ` [PATCH v5 03/13] gdb: Add get_main_func_start_pc to refactor frame.c:inside_main_func Christina Joos
2026-09-24 8:33 ` [PATCH v5 04/13] gdb: Refactor 'stack.c:print_frame' Christina Joos
2026-09-24 8:33 ` [PATCH v5 05/13] gdb: Introduce 'stack.c:print_pc' function without frame argument Christina Joos
2026-09-24 8:33 ` [PATCH v5 06/13] gdb: Refactor 'find_symbol_funname' and 'info_frame_command_core' in stack.c Christina Joos
2026-09-24 8:33 ` [PATCH v5 07/13] gdb: Refactor 'stack.c:print_frame_info' Christina Joos
2026-09-24 8:33 ` [PATCH v5 08/13] gdb: Add command option 'bt -shadow' to print the shadow stack backtrace Christina Joos
2026-09-24 9:37 ` Eli Zaretskii
2026-09-24 8:33 ` [PATCH v5 09/13] gdb: Provide gdbarch hook to distinguish shadow stack backtrace elements Christina Joos
2026-09-24 9:29 ` Eli Zaretskii
2026-09-24 13:10 ` Joos, Christina
2026-09-24 8:33 ` [PATCH v5 10/13] gdb: Implement the hook 'is_no_return_shadow_stack_address' for amd64 linux Christina Joos
2026-09-24 8:33 ` [PATCH v5 11/13] gdb: Enable inferior calls in the shadow stack backtrace Christina Joos
2026-09-24 8:33 ` [PATCH v5 12/13] gdb: Enable signal trampolines " Christina Joos
2026-09-24 8:33 ` [PATCH v5 13/13] gdb, mi: Add -shadow-stack-list-frames command Christina Joos
2026-09-24 9:39 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ld8ql5v1.fsf@linaro.org \
--to=thiago.bauermann@linaro.org \
--cc=christina.joos@intel.com \
--cc=gdb-patches@sourceware.org \
--cc=luis.machado.foss@gmail.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox