Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Christina Joos <christina.joos@intel.com>
Cc: gdb-patches@sourceware.org, thiago.bauermann@linaro.org,
	tom@tromey.com, luis.machado.foss@gmail.com
Subject: Re: [PATCH v5 13/13] gdb, mi: Add -shadow-stack-list-frames command
Date: Thu, 24 Sep 2026 12:39:36 +0300	[thread overview]
Message-ID: <86fqyz9eef.fsf@gnu.org> (raw)
In-Reply-To: <20260924083311.1961530-14-christina.joos@intel.com> (message from Christina Joos on Thu, 24 Sep 2026 10:33:10 +0200)

> From: Christina Joos <christina.joos@intel.com>
> Cc: thiago.bauermann@linaro.org, tom@tromey.com, luis.machado.foss@gmail.com
> Date: Thu, 24 Sep 2026 10:33:10 +0200
> 
> Add the mi command for the command "backtrace -shadow".
> Similar to the mi interface for the ordinary backtrace command,
> support low-frame and high-frame as command line parameters.
> 
> Example print of a full shadow stack backtrace:
> ~~~
> (gdb)
> -shadow-stack-list-frames
> ^done,shadow-stack=[
> shadow-stack-frame={level="0",addr="0x00007ffff7c3fe70",
>   func="__libc_start_call_main",file="../sysdeps/nptl/libc_start_call_main.h",
>   fullname="/usr/[...]/sysdeps/nptl/libc_start_call_main.h",
>   line="58",arch="i386:x86-64"},
> shadow-stack-frame={level="1",addr="0x00007ffff7c3ff20",
>   func="__libc_start_main_impl",file="../csu/libc-start.c",
>   fullname="/usr/[...]/csu/libc-start.c",
>   line="128",arch="i386:x86-64"},
> shadow-stack-frame={level="2",addr="0x0000000000401075",
>   func="_start",arch="i386:x86-64"}]
> ~~~
> 
> Example print of a shadow stack backtrace using low- and high-frame:
> ~~~
> (gdb)
> -shadow-stack-list-frames 0 1
> ^done,shadow-stack=[
> shadow-stack-frame={level="0",addr="0x00007ffff7c3fe70",
>   func="__libc_start_call_main",file="../sysdeps/nptl/libc_start_call_main.h",
>   fullname="/usr/[...]/sysdeps/nptl/libc_start_call_main.h",
>   line="58",arch="i386:x86-64"},
> shadow-stack-frame={level="1",addr="0x00007ffff7c3ff20",
>   func="__libc_start_main_impl",file="../csu/libc-start.c",
>   fullname="/usr/[...]/csu/libc-start.c",
>   line="128",arch="i386:x86-64"}]
> ~~~
> ---
>  gdb/NEWS                                      |   8 ++
>  gdb/doc/gdb.texinfo                           |  51 +++++++
>  gdb/mi/mi-cmd-stack.c                         |  95 +++++++++++++
>  gdb/mi/mi-cmds.c                              |   2 +
>  gdb/mi/mi-cmds.h                              |   1 +
>  gdb/shadow-stack.c                            | 127 +++++++++++++-----
>  gdb/shadow-stack.h                            |  43 ++++++
>  .../gdb.mi/mi-shadow-stack-signal.exp         |  69 ++++++++++
>  gdb/testsuite/gdb.mi/mi-shadow-stack.exp      |  93 +++++++++++++
>  9 files changed, 453 insertions(+), 36 deletions(-)
>  create mode 100644 gdb/testsuite/gdb.mi/mi-shadow-stack-signal.exp
>  create mode 100644 gdb/testsuite/gdb.mi/mi-shadow-stack.exp

Thanks, the documentation parts are okay.

Reviewed-By: Eli Zaretskii <eliz@gnu.org>

      reply	other threads:[~2026-09-24  9:40 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-24  8:32 [PATCH v5 00/13] Add new command to print the shadow stack backtrace Christina Joos
2026-09-24  8:32 ` [PATCH v5 01/13] gdb: Generalize handling of the shadow stack pointer Christina Joos
2026-09-24 21:03   ` Thiago Jung Bauermann
2026-09-24  8:32 ` [PATCH v5 02/13] aarch64: Implement gdbarch function top_addr_empty_shadow_stack Christina Joos
2026-09-24 21:04   ` Thiago Jung Bauermann
2026-09-24  8:33 ` [PATCH v5 03/13] gdb: Add get_main_func_start_pc to refactor frame.c:inside_main_func Christina Joos
2026-09-24  8:33 ` [PATCH v5 04/13] gdb: Refactor 'stack.c:print_frame' Christina Joos
2026-09-24  8:33 ` [PATCH v5 05/13] gdb: Introduce 'stack.c:print_pc' function without frame argument Christina Joos
2026-09-24  8:33 ` [PATCH v5 06/13] gdb: Refactor 'find_symbol_funname' and 'info_frame_command_core' in stack.c Christina Joos
2026-09-24  8:33 ` [PATCH v5 07/13] gdb: Refactor 'stack.c:print_frame_info' Christina Joos
2026-09-24  8:33 ` [PATCH v5 08/13] gdb: Add command option 'bt -shadow' to print the shadow stack backtrace Christina Joos
2026-09-24  9:37   ` Eli Zaretskii
2026-09-24  8:33 ` [PATCH v5 09/13] gdb: Provide gdbarch hook to distinguish shadow stack backtrace elements Christina Joos
2026-09-24  9:29   ` Eli Zaretskii
2026-09-24 13:10     ` Joos, Christina
2026-09-24  8:33 ` [PATCH v5 10/13] gdb: Implement the hook 'is_no_return_shadow_stack_address' for amd64 linux Christina Joos
2026-09-24  8:33 ` [PATCH v5 11/13] gdb: Enable inferior calls in the shadow stack backtrace Christina Joos
2026-09-24  8:33 ` [PATCH v5 12/13] gdb: Enable signal trampolines " Christina Joos
2026-09-24  8:33 ` [PATCH v5 13/13] gdb, mi: Add -shadow-stack-list-frames command Christina Joos
2026-09-24  9:39   ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86fqyz9eef.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=christina.joos@intel.com \
    --cc=gdb-patches@sourceware.org \
    --cc=luis.machado.foss@gmail.com \
    --cc=thiago.bauermann@linaro.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox