RE: [PATCH v5 09/13] gdb: Provide gdbarch hook to distinguish shadow stack backtrace elements.

["Joos, Christina" <christina.joos@intel.com>]

> -----Original Message-----
> From: Eli Zaretskii <eliz@gnu.org>
> Sent: Donnerstag, 24. September 2026 11:30
> To: Joos, Christina <christina.joos@intel.com>
> Cc: gdb-patches@sourceware.org; thiago.bauermann@linaro.org;
> tom@tromey.com; luis.machado.foss@gmail.com
> Subject: Re: [PATCH v5 09/13] gdb: Provide gdbarch hook to distinguish
> shadow stack backtrace elements.
> 
> > From: Christina Joos <christina.joos@intel.com>
> > Cc: thiago.bauermann@linaro.org, tom@tromey.com,
> > luis.machado.foss@gmail.com
> > Date: Thu, 24 Sep 2026 10:33:06 +0200
> >
> > On x86 with CET or on ARM with GCS, there can be elements on the
> > shadow stack which are not return addresses.  In this case, we don't
> > want to print the shadow stack element, but a string instead which
> > describes the frame similar to the normal backtrace command for dummy
> frames or signals.
> >
> > Provide a gdbarch hook to distinguish between return and non-return
> > addresses and to configure a string which is printed instead of the
> > shadow stack element.
> >
> > Reviewed-by: Thiago Jung Bauermann <thiago.bauermann@linaro.org>
> > ---
> >  gdb/doc/gdb.texinfo       | 19 +++++++++++++++++++
> >  gdb/gdbarch-gen.c         | 32 ++++++++++++++++++++++++++++++++
> >  gdb/gdbarch-gen.h         | 19 +++++++++++++++++++
> >  gdb/gdbarch_components.py | 25 +++++++++++++++++++++++++
> >  gdb/shadow-stack.c        | 36 +++++++++++++++++++++++++++++++++++-
> >  gdb/shadow-stack.h        | 26 ++++++++++++++++++++++++++
> >  6 files changed, 156 insertions(+), 1 deletion(-)
> 
> AFAIR, I've approved the gdb.texinfo part in v2, right?  And there are no
> changes in that part since then, right?

Hi Eli, 

Thanks a lot for the quick feedback. Yes, you reviewed this patch in v2 already.
And I just double-checked - the gdb.texinfo part did not change for this patch.
I will add your review tag, sorry for missing it.

The gdb.texinfo part did change a bit since v2 for
- "gdb: Add command option 'bt -shadow' to print the shadow stack backtrace"
- "gdb, mi: Add -shadow-stack-list-frames command"

But I saw that you just reviewed the 2 patches again (thanks!).

Christina

________________________________________
Intel Deutschland GmbH 

Registered Address: Dornacher Strasse 1, 85622 Feldkirchen, Germany 

Tel: +49 (89) 99143-0 

www.intel.de 

Managing Directors: Candice Moore, Jeffrey Schneiderman, Ramachandran Sitaraman

Chairperson of the Supervisory Board: Sonja Pierer

Registered Seat: Munich Commercial Register B: Amtsgericht Munich HRB 186928

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.