Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Christina Joos <christina.joos@intel.com>
Cc: gdb-patches@sourceware.org, thiago.bauermann@linaro.org,
	tom@tromey.com, luis.machado.foss@gmail.com
Subject: Re: [PATCH v5 08/13] gdb: Add command option 'bt -shadow' to print the shadow stack backtrace.
Date: Thu, 24 Sep 2026 12:37:27 +0300	[thread overview]
Message-ID: <86h5jf9ei0.fsf@gnu.org> (raw)
In-Reply-To: <20260924083311.1961530-9-christina.joos@intel.com> (message from Christina Joos on Thu, 24 Sep 2026 10:33:05 +0200)

> From: Christina Joos <christina.joos@intel.com>
> Cc: thiago.bauermann@linaro.org, tom@tromey.com, luis.machado.foss@gmail.com
> Date: Thu, 24 Sep 2026 10:33:05 +0200
> 
> Add command option '-shadow" to the backtrace command to print the shadow
> stack backtrace instead of the normal backtrace.
> 
> This option may be combined with '-frame-info' and implies '-no-filters'
> and '-frame-arguments none'.  Also the options @samp{-past-entry} or
> @samp{-hide} are not supported.
> 
> This is an example for the output of 'bt -shadow' on amd64 linux:
> ~~
> (gdb) bt -shadow
> /#0  0x000055555555514a in call1 at amd64-shadow-stack.c:27
> /#1  0x000055555555515f in main at amd64-shadow-stack.c:38
> ~~
> 
> Note that the normal backtrace includes one additional frame, since
> the shadow stack backtrace relies on return addresses of the shadow
> stack only.  But except the missing frame arguments and frame #0 of
> the normal backtrace, the backtrace is the same.
> ~~
> (gdb) bt
> /#0  call2 () at amd64-shadow-stack.c:21
> /#1  0x000055555555514a in call1 () at amd64-shadow-stack.c:27
> /#2  0x000055555555515f in main () at amd64-shadow-stack.c:38
> ~~
> 
> This commit also adds a test for 'bt -shadow' on amd64.
> Although the test is OS independent we can only test this on linux,
> as GDB does not support shadow stack on other OS for now.
> Also we do not add a test for 32 bit, as support for shadow stack is
> limited to 64 bit by the linux kernel.
> 
> Reviewed-by: Thiago Jung Bauermann <thiago.bauermann@linaro.org>
> ---
>  gdb/NEWS                                      |   3 +
>  gdb/doc/gdb.texinfo                           |  25 +
>  gdb/gdbarch-gen.h                             |   2 +
>  gdb/gdbarch.h                                 |   1 +
>  gdb/gdbarch_components.py                     |   2 +
>  gdb/shadow-stack.c                            | 475 ++++++++++++++++++
>  gdb/shadow-stack.h                            |  65 +++
>  gdb/stack.c                                   |  49 +-
>  gdb/stack.h                                   |  43 ++
>  .../gdb.arch/amd64-shadow-stack-cmds.exp      |  47 ++
>  gdb/testsuite/gdb.base/options.exp            |   2 +-
>  11 files changed, 689 insertions(+), 25 deletions(-)

Thanks, the documentation parts are okay.

Reviewed-By: Eli Zaretskii <eliz@gnu.org>

  reply	other threads:[~2026-09-24  9:37 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-24  8:32 [PATCH v5 00/13] Add new command " Christina Joos
2026-09-24  8:32 ` [PATCH v5 01/13] gdb: Generalize handling of the shadow stack pointer Christina Joos
2026-09-24 21:03   ` Thiago Jung Bauermann
2026-09-24  8:32 ` [PATCH v5 02/13] aarch64: Implement gdbarch function top_addr_empty_shadow_stack Christina Joos
2026-09-24 21:04   ` Thiago Jung Bauermann
2026-09-24  8:33 ` [PATCH v5 03/13] gdb: Add get_main_func_start_pc to refactor frame.c:inside_main_func Christina Joos
2026-09-24  8:33 ` [PATCH v5 04/13] gdb: Refactor 'stack.c:print_frame' Christina Joos
2026-09-24  8:33 ` [PATCH v5 05/13] gdb: Introduce 'stack.c:print_pc' function without frame argument Christina Joos
2026-09-24  8:33 ` [PATCH v5 06/13] gdb: Refactor 'find_symbol_funname' and 'info_frame_command_core' in stack.c Christina Joos
2026-09-24  8:33 ` [PATCH v5 07/13] gdb: Refactor 'stack.c:print_frame_info' Christina Joos
2026-09-24  8:33 ` [PATCH v5 08/13] gdb: Add command option 'bt -shadow' to print the shadow stack backtrace Christina Joos
2026-09-24  9:37   ` Eli Zaretskii [this message]
2026-09-24  8:33 ` [PATCH v5 09/13] gdb: Provide gdbarch hook to distinguish shadow stack backtrace elements Christina Joos
2026-09-24  9:29   ` Eli Zaretskii
2026-09-24 13:10     ` Joos, Christina
2026-09-24  8:33 ` [PATCH v5 10/13] gdb: Implement the hook 'is_no_return_shadow_stack_address' for amd64 linux Christina Joos
2026-09-24  8:33 ` [PATCH v5 11/13] gdb: Enable inferior calls in the shadow stack backtrace Christina Joos
2026-09-24  8:33 ` [PATCH v5 12/13] gdb: Enable signal trampolines " Christina Joos
2026-09-24  8:33 ` [PATCH v5 13/13] gdb, mi: Add -shadow-stack-list-frames command Christina Joos
2026-09-24  9:39   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86h5jf9ei0.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=christina.joos@intel.com \
    --cc=gdb-patches@sourceware.org \
    --cc=luis.machado.foss@gmail.com \
    --cc=thiago.bauermann@linaro.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox