Re: [RFC] decimal float point patch based on libdecnumber: gdb patch

[Wu Zhou <woodzltc@cn.ibm.com>]

Eli,

Thanks for your comments!  See below for my response.

On Thu, 22 Jun 2006, Eli Zaretskii wrote:

> > Date: Thu, 22 Jun 2006 07:36:17 +0800 (CST)
> > From: Wu Zhou <woodzltc@cn.ibm.com>
> > 
> > 
> > Appended is the patch.  I had tested it with the latest gcc-4.2 cvs tree 
> > on x86, with option "--enable-decimal-float". All the 121 tests passed.
> 
> Thanks.
> 
> > Please review and comment.  Thanks a lot.
> 
> Does this patch affect user-visible behavior in any way?  If so, we
> need to reflect that in the user manual.

Yes. I am thinking of adding some text to describe this.

> 
> > 	* Makefile.in: Add decimal floating point related entry.  Add
> > 	some macro to specify the libdecnumber directory, cflags and the
> > 	name of libdecnumber library.
> 
> The ChangeLog entry for Makefile.in should cite the target(s) and
> macros in which you made the changes, as if they were functions in a
> source file.

Thanks for the correction.  I didn't add any changelog for such things 
(Makefile.in) before.  Learn something new.  :-)  Will change that in the 
next round patch.

Regards
- Wu Zhou