Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Wu Zhou <woodzltc@cn.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC] decimal float point patch based on libdecnumber: gdb    	patch
Date: Tue, 22 Aug 2006 01:31:00 -0000	[thread overview]
Message-ID: <20060821160834.GA22192@nevyn.them.org> (raw)
In-Reply-To: <44E9D816.9070809@cn.ibm.com>

On Mon, Aug 21, 2006 at 11:58:14PM +0800, Wu Zhou wrote:
> But as far as I know, the endianess of struct "value" in the target memory 
> is architecture depedent. To name a example, in value_from_decfloat, we 
>  need to set the raw content of val to the dfp constant user inputed, I am 
> using this:
>   memcpy (value_contents_raw (val), decbytes, len);
> 
> decbytes is big-endian on all both x86 and ppc64 platforms.  But the 
> value_contents_raw (val) is little endian on x86 / x86_64 system, and big 
> endian on ppc64.  So exchange_dfp is needed.

No, that's not right.  The format of the byte buffer in struct value is
supposed to match the target representation of the object being
described.  If this is always big endian on the target, it should be
big endian in GDB too.

You can think of it like this:

struct A
{
  char a, b, c, d, e, f, g, h;
};

The first byte in the value buffer is supposed to match "char a", no
matter what the target endianness is.

Does that help, or am I not understanding the problem?

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2006-08-21 16:08 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-21 16:08 Wu Zhou
2006-08-21 18:30 ` Daniel Jacobowitz
2006-08-21 18:34   ` Wu Zhou
2006-08-22  1:31     ` Daniel Jacobowitz [this message]
2006-09-03  8:53       ` Wu Zhou
2006-09-03 16:44         ` Daniel Jacobowitz
2006-09-05  2:34           ` Wu Zhou
  -- strict thread matches above, loose matches on Subject: below --
2006-08-01  9:55 Wu Zhou
2006-08-01 10:51 ` Wu Zhou
2006-08-08 18:16   ` Daniel Jacobowitz
2006-07-23  5:48 Wu Zhou
2006-07-23 14:02 ` Daniel Jacobowitz
2006-06-21 21:03 [RFC] decimal float point patch based on libdecnumber: testcase Wu Zhou
2006-06-21 23:36 ` [RFC] decimal float point patch based on libdecnumber: gdb patch Wu Zhou
2006-06-22  3:27   ` Eli Zaretskii
2006-06-22 14:18     ` Wu Zhou
2006-07-12 20:39   ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060821160834.GA22192@nevyn.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    --cc=woodzltc@cn.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox