From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10048 invoked by alias); 22 Jun 2006 14:18:23 -0000 Received: (qmail 10038 invoked by uid 22791); 22 Jun 2006 14:18:22 -0000 X-Spam-Check-By: sourceware.org Received: from ausmtp05.au.ibm.com (HELO ausmtp05.au.ibm.com) (202.81.18.154) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 22 Jun 2006 14:18:19 +0000 Received: from sd0112e0.au.ibm.com (d23rh903.au.ibm.com [202.81.18.201]) by ausmtp05.au.ibm.com (8.13.6/8.13.6) with ESMTP id k5MELD1v5828636 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL) for ; Fri, 23 Jun 2006 00:21:16 +1000 Received: from d23av04.au.ibm.com (d23av04.au.ibm.com [9.190.250.237]) by sd0112e0.au.ibm.com (8.13.6/NCO/VER7.0) with ESMTP id k5MELM7h252046 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Fri, 23 Jun 2006 00:21:28 +1000 Received: from d23av04.au.ibm.com (loopback [127.0.0.1]) by d23av04.au.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id k5MEHHln024869 for ; Fri, 23 Jun 2006 00:17:17 +1000 Received: from [9.65.96.103] (sig-9-65-96-103.mts.ibm.com [9.65.96.103]) by d23av04.au.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id k5MEGrop022165; Fri, 23 Jun 2006 00:17:15 +1000 Date: Thu, 22 Jun 2006 14:18:00 -0000 From: Wu Zhou To: Eli Zaretskii cc: drow@false.org, gdb-patches@sourceware.org Subject: Re: [RFC] decimal float point patch based on libdecnumber: gdb patch In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-06/txt/msg00323.txt.bz2 Eli, Thanks for your comments! See below for my response. On Thu, 22 Jun 2006, Eli Zaretskii wrote: > > Date: Thu, 22 Jun 2006 07:36:17 +0800 (CST) > > From: Wu Zhou > > > > > > Appended is the patch. I had tested it with the latest gcc-4.2 cvs tree > > on x86, with option "--enable-decimal-float". All the 121 tests passed. > > Thanks. > > > Please review and comment. Thanks a lot. > > Does this patch affect user-visible behavior in any way? If so, we > need to reflect that in the user manual. Yes. I am thinking of adding some text to describe this. > > > * Makefile.in: Add decimal floating point related entry. Add > > some macro to specify the libdecnumber directory, cflags and the > > name of libdecnumber library. > > The ChangeLog entry for Makefile.in should cite the target(s) and > macros in which you made the changes, as if they were functions in a > source file. Thanks for the correction. I didn't add any changelog for such things (Makefile.in) before. Learn something new. :-) Will change that in the next round patch. Regards - Wu Zhou