Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Wu Zhou <woodzltc@cn.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC] decimal float point patch based on libdecnumber: testcase
Date: Thu, 22 Jun 2006 20:25:00 -0000	[thread overview]
Message-ID: <20060622202457.GA22230@nevyn.them.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0606220445480.2734@localhost.localdomain>

Hi Wu,

By and large this looks very good.  There are a couple of minor
formatting issues, which I'll run through for you when I get a chance
if no one else does; it may not be until after the GCC Summit next
week, though.

Moving libdecnumber into src is a bit tricky.  I'll take care of that
when we're ready for the patch.  It also has to go into src-release,
CVSROOT/modules, and some dependencies in Makefile.def.  So don't worry
about that.

I did have one question for you.  This struck me as strange...

On Thu, Jun 22, 2006 at 05:03:34AM +0800, Wu Zhou wrote:
> +    # _Decimal64 constants, which can support up to 16 digits
> +    gdb_test "p 1.2dd" " = 1.2"
> +    gdb_test "p -1.2dd" " = -1.2"
> +    gdb_test "p 1.234567890123456dd" " = 1.234567890123456"
> +    gdb_test "p -1.234567890123456dd" " = -1.234567890123456"
> +    gdb_test "p 1234567890123456.dd" " = 1234567890123456"
> +    gdb_test "p -1234567890123456.dd" " = -1234567890123456"
> +
> +    gdb_test "p 1.2E1dd" " = 12"
> +    gdb_test "p 1.2E10dd" " = 1.2E\\+10"

If "p 1234567890123456.dd" prints it back with digits, why does "p
1.2E10dd" print it back with an exponent?  Which would
"p 1200000000000000.dd" do?

> +proc test_arithmetic_expressions {} {
> +
> +# Arithmetic operations for DFP types are not yet implemented in GDB.
> +
> +}

Might want some tests for whatever does happen if you try it, in the
meantime.  It should give a sensible error message.

-- 
Daniel Jacobowitz
CodeSourcery


  parent reply	other threads:[~2006-06-22 20:25 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-21 21:03 Wu Zhou
2006-06-21 23:36 ` [RFC] decimal float point patch based on libdecnumber: gdb patch Wu Zhou
2006-06-22  3:27   ` Eli Zaretskii
2006-06-22 14:18     ` Wu Zhou
2006-07-12 20:39   ` Daniel Jacobowitz
2006-06-22 20:25 ` Daniel Jacobowitz [this message]
2006-06-22 23:27   ` [RFC] decimal float point patch based on libdecnumber: testcase Wu Zhou
2006-06-23  2:38     ` Daniel Jacobowitz
2006-06-23 18:39       ` Wu Zhou
2006-06-23 18:49         ` Daniel Jacobowitz
2006-06-23 19:25           ` Wu Zhou
2006-06-23 19:51             ` Daniel Jacobowitz
2006-07-11 15:35 Wu Zhou
2006-07-12 17:16 ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060622202457.GA22230@nevyn.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    --cc=woodzltc@cn.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox