From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27040 invoked by alias); 22 Jun 2006 20:25:04 -0000 Received: (qmail 27032 invoked by uid 22791); 22 Jun 2006 20:25:04 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Thu, 22 Jun 2006 20:25:00 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1FtVjV-00068Q-9U; Thu, 22 Jun 2006 16:24:57 -0400 Date: Thu, 22 Jun 2006 20:25:00 -0000 From: Daniel Jacobowitz To: Wu Zhou Cc: gdb-patches@sourceware.org Subject: Re: [RFC] decimal float point patch based on libdecnumber: testcase Message-ID: <20060622202457.GA22230@nevyn.them.org> Mail-Followup-To: Wu Zhou , gdb-patches@sourceware.org References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.11+cvs20060403 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-06/txt/msg00337.txt.bz2 Hi Wu, By and large this looks very good. There are a couple of minor formatting issues, which I'll run through for you when I get a chance if no one else does; it may not be until after the GCC Summit next week, though. Moving libdecnumber into src is a bit tricky. I'll take care of that when we're ready for the patch. It also has to go into src-release, CVSROOT/modules, and some dependencies in Makefile.def. So don't worry about that. I did have one question for you. This struck me as strange... On Thu, Jun 22, 2006 at 05:03:34AM +0800, Wu Zhou wrote: > + # _Decimal64 constants, which can support up to 16 digits > + gdb_test "p 1.2dd" " = 1.2" > + gdb_test "p -1.2dd" " = -1.2" > + gdb_test "p 1.234567890123456dd" " = 1.234567890123456" > + gdb_test "p -1.234567890123456dd" " = -1.234567890123456" > + gdb_test "p 1234567890123456.dd" " = 1234567890123456" > + gdb_test "p -1234567890123456.dd" " = -1234567890123456" > + > + gdb_test "p 1.2E1dd" " = 12" > + gdb_test "p 1.2E10dd" " = 1.2E\\+10" If "p 1234567890123456.dd" prints it back with digits, why does "p 1.2E10dd" print it back with an exponent? Which would "p 1200000000000000.dd" do? > +proc test_arithmetic_expressions {} { > + > +# Arithmetic operations for DFP types are not yet implemented in GDB. > + > +} Might want some tests for whatever does happen if you try it, in the meantime. It should give a sensible error message. -- Daniel Jacobowitz CodeSourcery