Re: [RFC] GDB patches for hw watchpoints - revised

[Wu Zhou <woodzltc@cn.ibm.com>]

On Thu, 9 Feb 2006, Eli Zaretskii wrote:

> > Date: Thu, 9 Feb 2006 13:43:14 +0800 (CST)
> > From: Wu Zhou <woodzltc@cn.ibm.com>
> > cc: Eli Zaretskii <eliz@gnu.org>, gdb-patches@sources.redhat.com,
> >         bje@au1.ibm.com, anton@au1.ibm.com, pgilliam@us.ibm.com
> > 
> > Daniel,
> > 
> > I committed the two patches you approved.  Here is a seperate patch for 
> > gdbint.texinfo:
> > 
> > 2006-02-08  Wu Zhou  <woodzltc@cn.ibm.com>
> > 
> > 	* gdbint.texinfo (TARGET_REGION_SIZE_OK_FOR_HW_WATCHPOINT): Delete.
> 
> The patch to gdb.texinfo is approved, but this ChangeLog entry is
> incorrect.  What should be in the parentheses is the name of the node
> where the changes were made.  The text then should say "Delete
> TARGET_REGION_SIZE_OK_FOR_HW_WATCHPOINT.".  Okay?
> 

Thanks.  I committed this:

2006-02-13  Wu Zhou  <woodzltc@cn.ibm.com>

	* gdbint.texinfo (Watchpoints): Delete
	TARGET_REGION_SIZE_OK_FOR_HW_WATCHPOINT.

Index: gdbint.texinfo
===================================================================
RCS file: /cvs/src/src/gdb/doc/gdbint.texinfo,v
retrieving revision 1.238
diff -c -p -r1.238 gdbint.texinfo
*** gdbint.texinfo	6 Feb 2006 22:14:31 -0000	1.238
--- gdbint.texinfo	9 Feb 2006 05:32:27 -0000
*************** the same time).
*** 465,477 ****
  Return non-zero if hardware watchpoints can be used to watch a region
  whose address is @var{addr} and whose length in bytes is @var{len}.
  
- @findex TARGET_REGION_SIZE_OK_FOR_HW_WATCHPOINT
- @item TARGET_REGION_SIZE_OK_FOR_HW_WATCHPOINT (@var{size})
- Return non-zero if hardware watchpoints can be used to watch a region
- whose size is @var{size}.  @value{GDBN} only uses this macro as a
- fall-back, in case @code{TARGET_REGION_OK_FOR_HW_WATCHPOINT} is not
- defined.
- 
  @cindex insert or remove hardware watchpoint
  @findex target_insert_watchpoint
  @findex target_remove_watchpoint
--- 465,470 ----

Regards
- Wu Zhou